-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restoreKeybackup
to CryptoApi
.
#4476
Add restoreKeybackup
to CryptoApi
.
#4476
Conversation
bc49f0b
to
65bf2b0
Compare
65bf2b0
to
5e9ed6b
Compare
5e9ed6b
to
61c1940
Compare
Sounds sensible.
No. There is no real reason for applications to be restoring keys at the room level (and certainly not at the session level). The crypto stack will fetch keys on demand. Let's drop support for those parameters.
Yeah, I think that it makes sense to mark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a very sensible start. Obviously, please make sure that any new public types and methods are clearly documented, but I think you know that.
eaa2357
to
d385c72
Compare
…ekeybackup # Conflicts: # src/rust-crypto/backup.ts
bad71c7
to
e55aee9
Compare
…pPrivateKeyFromSecretStorage`
db068a4
to
250b7e9
Compare
…BackupInfo` parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
Checklist
public
/exported
symbols have accurate TSDoc documentation.Task element-hq/element-web#26922
The goal is to simplify the
restoreKeyBackup
api and move it out of theMatrixClient
to theCryptoApi
.CryptoApi
restoreKeyBackup
RestoreKeyBackupDialog
we never target a specific session or room when calling therestoreKeyBackup*
consequently I get rid of thetargetRoomId
andtargetSessionId
.IKeyBackupRestoreOpts.cacheCompleteCallback
is not used inRestoreKeyBackupDialog
, I removed also this parameter.keyBackupInfo
as a parameter, we directly retrieve it internally.restoreKeyBackupWithPassphrase
which is deprecated because deriving a key backup from the passphrase is not in the spec.RustBackupManager.
restoreKeyBackup*
inMatrixClient