Send/receive error details with widgets

[AndrewFerr]

Depends on matrix-org/matrix-widget-api#100

Signed-off-by: Andrew Ferrazzutti andrewf@element.io

Checklist

• Tests written for new code (and old code if feasible).
• New or updated public/exported symbols have accurate TSDoc documentation.
• Linter and other CI checks pass.
• Sign-off given on the changes (see CONTRIBUTING.md).

[t3chguy]

Why do we need this bind?

[AndrewFerr]

This is used as a way to preserve the original send method so it can still be used by the function that replaces it.

Alternatively this could have been an arrow function, but that would require specifying a parameter list. Using bind gets around that.

[t3chguy]

This seems like a really nasty pattern, this looks like somewhere a subclass makes far more sense rather than overwriting class methods, what's the rationale for not doing it in a more conventional way?

[AndrewFerr]

It's because the send methods don't belong to WidgetApi, but to ITransport, meaning that subclassing (or even a composition-based approach) would have to work harder to get to them.

Any non-bind approach I can think of ends up being more complicated / requires much more copied code than this.