Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shield status codes from Rust rather than string matching #4529

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Use shield status codes from Rust rather than string matching #4529

wants to merge 2 commits into from

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Nov 14, 2024 •
edited
Loading

Also add EventShieldReasons to match. Part of fixing element-hq/element-web#28170
See also element-hq/element-web#28476

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@uhoreg uhoreg added the T-Task Tasks for the team like planning label Nov 14, 2024
@uhoreg uhoreg mentioned this pull request Nov 15, 2024
Open
4 tasks
@uhoreg uhoreg marked this pull request as ready for review November 15, 2024 20:54
@uhoreg uhoreg requested a review from a team as a code owner November 15, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr BillCarsonFr is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uhoreg @andybalaam