Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing support for fetching homeserver unstable features (ffi MSC4028) #3191

Closed
hanadi92 opened this issue Mar 6, 2024 · 0 comments · Fixed by #3192
Closed

Missing support for fetching homeserver unstable features (ffi MSC4028) #3191

hanadi92 opened this issue Mar 6, 2024 · 0 comments · Fixed by #3192

Comments

@hanadi92
Copy link
Contributor

hanadi92 commented Mar 6, 2024

Description:

Missing support for retrieving and holding onto the unstable_features from /_matrix/clients/versions. Currently, only the versions key is fetched and used later.

Use Case:

According to MSC4028, clients should should check for the state of unstable feature MSC4028 on the homeserver.

To ensure the server supports the functionality before a spec release, clients should interpret an unstable feature org.matrix.msc4028 with a value of true in the response of the /_matrix/clients/versions endpoint as the feature being supported by the homeserver. Once released in the specification, clients should be checking for server support through advertised spec versions instead.
@hanadi92 hanadi92 changed the title Missing support for fetching homeserver unstable features Missing support for fetching homeserver unstable features (ffi MSC4028) Mar 6, 2024
@hanadi92 hanadi92 mentioned this issue Mar 6, 2024
Merged
1 task
bnjbvr added a commit that referenced this issue Mar 8, 2024
@hanadi92 @bnjbvr
sdk&ffi: server unstable features support for MSC4028 (#3192)
724d133 
Fixes #3191

Allows support for fetching the unstable_features from `/_matrix/clients/versions`.
Specifically, to be used for checking the state of org.matrix.msc4028 through ffi to the clients.

---

* sdk: fetch unstable_features supported by homeserver

Signed-off-by: hanadi92 <hanadi.tamimi@gmail.com>

* ffi: add can_homeserver_push_encrypted_event_to_device method

Signed-off-by: hanadi92 <hanadi.tamimi@gmail.com>

* fix: use copied instead of dereferencing

Co-authored-by: Benjamin Bouvier <public@benj.me>
Signed-off-by: Hanadi <hanadi.tamimi@gmail.com>

* fix: move can_homeserver_push_encrypted_event_to_device logic to sdk

Signed-off-by: hanadi92 <hanadi.tamimi@gmail.com>

* fix: remove unused unstable features param in client builder

Signed-off-by: hanadi92 <hanadi.tamimi@gmail.com>

* fix: use assert instead of asserteq for bool check

Signed-off-by: hanadi92 <hanadi.tamimi@gmail.com>

* fix: documentation

Signed-off-by: hanadi92 <hanadi.tamimi@gmail.com>

* Apply suggestions from code review

Signed-off-by: Benjamin Bouvier <public@benj.me>

---------

Signed-off-by: hanadi92 <hanadi.tamimi@gmail.com>
Signed-off-by: Hanadi <hanadi.tamimi@gmail.com>
Signed-off-by: Benjamin Bouvier <public@benj.me>
Co-authored-by: Benjamin Bouvier <public@benj.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sdk&ffi: server unstable features support for MSC4028 hanadi92/matrix-rust-sdk
1 participant
@hanadi92