Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Change the installer for setup-matrix-synapse #2198

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Jul 3, 2023

There is a bug in Synapse and changing the installer seems to fix the problem.

Trying to apply michaelkaye/setup-matrix-synapse#94 (comment) :-).

@Hywan Hywan requested a review from a team as a code owner July 3, 2023 10:44
@Hywan Hywan requested review from jplatte and removed request for a team July 3, 2023 10:44
There is a bug in Synapse and changing the installer seems to fix the
problem.
@Hywan Hywan requested a review from jplatte July 3, 2023 10:47
@Hywan
Copy link
Member Author

Hywan commented Jul 3, 2023

@jplatte I'm asking a new review as I've replaced gnunicorn/setup-matrix-synapse by michaelkaye/setup-matrix-synapse in .github/workflows/coverage.yml.

@poljar
Copy link
Contributor

poljar commented Jul 3, 2023

I think now you're hitting: matrix-org/synapse#15858

@jplatte
Copy link
Collaborator

jplatte commented Jul 3, 2023

I wonder if we needed Ben's patch. In any case I think our serverName is now ineffective. This is what the forked action was doing differently: michaelkaye/setup-matrix-synapse#50

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (3180a1b) 76.72% compared to head (c955de8) 76.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2198      +/-   ##
==========================================
+ Coverage   76.72%   76.73%   +0.01%     
==========================================
  Files         164      164              
  Lines       17639    17640       +1     
==========================================
+ Hits        13533    13536       +3     
+ Misses       4106     4104       -2     
Impacted Files Coverage Δ
crates/matrix-sdk-ui/src/room_list_service/room.rs 91.30% <ø> (ø)
...s/matrix-sdk-ui/src/room_list_service/room_list.rs 100.00% <ø> (ø)
crates/matrix-sdk-ui/src/room_list_service/mod.rs 96.51% <100.00%> (ø)
...rates/matrix-sdk-ui/src/room_list_service/state.rs 94.54% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@poljar
Copy link
Contributor

poljar commented Jul 3, 2023

Oh, it actually passed CI, nice.

@Hywan Hywan merged commit 746b130 into matrix-org:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants