Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2666: Get rooms in common with another user #2666

Open
wants to merge 29 commits into
base: old_master
Choose a base branch
from
Open
Changes from 24 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c61790e
MSC 2664: Get rooms in common with another user
Half-Shot Jul 5, 2020
4264f32
correct MSC number
Half-Shot Jul 5, 2020
008951f
Try to clarify Proposal, update response format
Half-Shot Jul 5, 2020
29f02ed
Update MSC number in prefix
Half-Shot Jul 5, 2020
2b75da8
Wording tidyup
Half-Shot Jul 5, 2020
630af1c
more tidyup
Half-Shot Jul 5, 2020
d885bcf
Clarify empty responses
Half-Shot Jul 5, 2020
5254076
uhoreg fixes my spelling
Half-Shot Jul 5, 2020
3f2faef
add same user case
Half-Shot Jul 6, 2020
db99583
Update to use /uk.half-shot.msc2666/
Half-Shot Jul 10, 2020
10a2df2
Fixes
Half-Shot Jul 20, 2020
d3b17e6
Merge branch 'hs/shared-rooms' of github.com:matrix-org/matrix-doc in…
Half-Shot Jul 20, 2020
4ac7ce8
remove referneces to user_id
Half-Shot Jul 20, 2020
a4f5bae
another reference to the auth user id
Half-Shot Jul 20, 2020
c453704
consistent newlines
Half-Shot Jul 20, 2020
cd173d5
Add errcode
Half-Shot Aug 18, 2020
1a389f9
Update proposals/2666-get-rooms-in-common.md
Half-Shot Aug 18, 2020
fbbb2d9
typo fix and shared_rooms -> mutual_rooms (#3631)
ShadowJonathan Jan 9, 2022
591d3e5
Apply suggestions from code review
Half-Shot Apr 12, 2022
a1de65f
@MSC2666: Add "may return 400" qualifier (#3770)
ShadowJonathan Apr 13, 2022
d59d051
Reject r0, embrace v1
Half-Shot Apr 15, 2022
6a4e523
Remove M_UNKNOWN response (#3822)
ShadowJonathan May 31, 2022
b946cc3
Update an old link to the spec; fix endpoint text
anoadragon453 Aug 2, 2022
ea49670
provide a link to lazy-loading of room members spec
anoadragon453 Aug 2, 2022
6f4f01b
Apply review feedback (#3913)
ShadowJonathan Jan 31, 2023
60ae94f
Add invalid batch_token error code (#4017)
ShadowJonathan May 18, 2023
7829c3b
Update proposals/2666-get-rooms-in-common.md
anoadragon453 May 19, 2023
92aef5b
restrict the allowed characters for the next_batch_token
anoadragon453 Jun 5, 2023
d58d0a1
apply review feedback (#4035)
ShadowJonathan Jul 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions proposals/2666-get-rooms-in-common.md
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
# MSC 2666: Get rooms in common with another user
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved

It is useful to be able to fetch rooms you have in common with another user. Popular messaging services
such as Telegram offer users the ability to show "groups in common", which allows users to determine
what they have in common before participating in conversation.

There are a variety of applications for this information. Some users may want to block invites from
users they do not share a room with at the client level, and need a way to poll the homeserver for
this information. Another use case would be trying to determine how a user came across your MXID, as
invites on their own do not present much context. With this endpoint, a client could tell you what
rooms you have in common before you accept an invite.

While this information can be determined if the user has full access to member state for all rooms,
modern clients often implement [lazy-loading of room members](https://spec.matrix.org/v1.3/client-server-api/#lazy-loading-room-members),
so they often only have a subset of state for the rooms the user is in. Therefore, the homeserver
should have a means to provide this information.

This proposal aims to implement a simple mechanism to fetch rooms you have in common with another user.


## Proposal

Homeservers should implement a new endpoint `/_matrix/client/v1/user/mutual_rooms/{user_id}` which will take
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved
the MxID of the user who is being searched for.

The response format will be an array containing all rooms where both the authenticated user and `user_id` have
a membership of type `join`. If the `user_id` does not exist, or does not share any rooms with the authenticated user,
an empty array should be returned.
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved

```
GET /_matrix/client/v1/user/mutual_rooms/%40bob%3Aexample.com
```

```json
{
"joined": [
"!OGEhHVWSdvArJzumhm:matrix.org",
turt2live marked this conversation as resolved.
Show resolved Hide resolved
"!HYlSnuBHTxUPgyZPKC:half-shot.uk",
"!DueayyFpVTeVOQiYjR:example.com"
]
}
```

anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved
The response error for trying to get shared rooms with yourself will be an HTTP code 400, with `M_FORBIDDEN` as the `errcode`.
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved

## Potential issues

Homeserver performance and storage may be impacted by this endpoint. While a homeserver already stores
membership information for each of its users, the information may not be stored in a way that is readily
accessible. Homeservers that have implemented [POST /user_directory/search](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3user_directorysearch)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the performance impact will be OK if this endpoint is used "infrequently", i.e. like for the use cases described in the intro.

Basically: the query requires looking up the list of rooms for each user and doing the intersection, which is not cheap, but is also not particularly expensive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, in Element's case, I expect this endpoint to be hit in a few cases;

  • Explicitly opening a detail profile view (e.g. clicking on a profile in the sidebar in cinny in element).
  • Upon viewing invites (to cross-reference where the person is known from).
  • When viewing a minimal DM, where the header ("This is your conversation with X") is visible.

I don't expect it to be pre-loaded en-masse, or loaded en-masse in general.

may have started some of this work, if they are limiting users to searching for users for which they
share rooms. While this is not a given by any means, it may mean that implementations of this API
and /search may be complimentary.
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved


## Alternatives
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved

A client which holds full and current state can already see all membership for all rooms, and thus
determine which of those rooms contains a "join" membership for the given user_id. Clients which "lazy-load"
however do not have this information, as they will have only synced a subset of the full membership for
all rooms. While a client *could* pull all membership for all rooms at the point of needing this information,
it's computationally expensive for both the homeserver and the client, as well as a bandwidth waste for constrained
clients.


## Security considerations

The information provided in this endpoint is already accessible to the client if it has a copy of all
state that the user can see. This endpoint only makes it possible to get this information without having
to request all state ahead of time.


## Unstable prefix

The implementation MUST use `/_matrix/client/unstable/uk.half-shot.msc2666/user/mutual_rooms/{user_id}`.
The /versions endpoint MUST include a new key in `unstable_features` with the name `uk.half-shot.msc2666.mutual_rooms`.
If the value is false or the key is not present, clients MUST assume the feature is not available.
Once the MSC has been merged, clients should use `/_matrix/client/v1/user/mutual_rooms/{user_id}`
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved
and will no longer need to check for the `unstable_features` flag.