Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to make use of unstable prefixes in your MSC #4024

Merged
merged 8 commits into from
Jul 7, 2023

Conversation

anoadragon453
Copy link
Member

This PR adds a section to the simple spec guide that gives some background to MSC authors on how to effectively make use of unstable and stable prefixes.

This commit adds a section to the simple spec guide that gives some
background to MSC authors on how to effectively make use of unstable
and stable prefixes.
@anoadragon453 anoadragon453 marked this pull request as ready for review June 1, 2023 15:00
@anoadragon453 anoadragon453 requested a review from a team June 1, 2023 15:00
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm with the verbiage changes noted already

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
With a value of `true` indicating that the feature is supported, and `false`
or lack of the field altogether indicating the feature is not supported.

According to the spec process, once an MSC has been accepted, implementations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
According to the spec process, once an MSC has been accepted, implementations
According to the spec process, once an MSC has been accepted (passed a `merge` FCP), implementations

... or we should mention this somewhere in the doc if we don't already

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
anoadragon453 and others added 3 commits July 3, 2023 10:23
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Plus a bit of paragraph reflow, sorry.
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@anoadragon453 anoadragon453 merged commit f7b3903 into main Jul 7, 2023
1 check passed
@anoadragon453 anoadragon453 deleted the anoa/prefix_clarifications branch July 7, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants