MSC4076: Let E2EE clients calculate app & E2EE-room badge counts themselves #4076
Conversation
turt2live
added
push
proposal
| @@ -0,0 +1,127 @@ | |||
| # MSC4076: Let E2EE clients calculate app badge counts themselves | |||
There was a problem hiding this comment.
I fail to see how you couldn't already calculate them clientside?
There was a problem hiding this comment.
Agreed. TBH I've only skimmed this, but I don't entirely follow why this MSC is necessary for clients to calculate their own badge counts.
(You might justifiably argue that the counts should be removed on the grounds of redundancy, but that doesn't appear to be what this MSC is saying?)
There was a problem hiding this comment.
You can and should calculate them clientside. However, the server currently overrides them and there is no way to stop the server from doing that, prior to this MSC.
There was a problem hiding this comment.
Clearly some crucial information is missing here? Since to my understanding you can just make either fully ignore the server response and do it without it or have an if case for only e2ee rooms. I don't see how that currently impossible? The server isn't demanding a particular execution path on the client obviously?
There was a problem hiding this comment.
However, the server currently overrides them and there is no way to stop the server from doing that, prior to this MSC.
Is this done at the OS-level and the server needs to not include that information to not fight the client doing it?
There was a problem hiding this comment.
Is this done at the OS-level and the server needs to not include that information to not fight the client doing it?
yes.
There was a problem hiding this comment.
(this is why literally the first sentence in the proposal is explaining this behaviour and linking to the apple documentation that describes it)
This gives a way for E2EE-aware clients to accurately maintain their own app badge counts, rather than having the server incorrectly override them based on partial information.
Solves element-hq/element-x-ios#2993 (and is a full soln to element-hq/element-x-ios#2066)
Rendered