Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require proof implementations for MSCs to be open source #1653

Open
ara4n opened this issue Oct 2, 2023 · 3 comments
Open

Require proof implementations for MSCs to be open source #1653

ara4n opened this issue Oct 2, 2023 · 3 comments
Labels
improvement An idea/future MSC for the spec

Comments

@ara4n
Copy link
Member

ara4n commented Oct 2, 2023

MSCs require an implementation to demonstrate that the MSC works. If that implementation is closed-source then it's impossible to verify that it proves that the MSC works as intended (it could be doing anything). So we should probably clarify that MSCs proofs need to be FOSS.

@ara4n ara4n added the improvement An idea/future MSC for the spec label Oct 2, 2023
@ara4n
Copy link
Member Author

ara4n commented Oct 2, 2023

on further discussion in the SCT, the conclusion was that the current wording may be sufficient: the implementation needs to prove that the MSC works. That might well mean that you have to inspect the source of the implementation to be comfortable that it actually does what it claims to be doing. However, on the other hand, it may also be sufficient to interrogate a closed API (which apparently we did already with an MSC from Beeper) to get confidence that that the MSC is going to work.

So, keeping it flexible (and not dissuading commercial vendors from contributing MSCs) might be the better course of valour here... on the understanding that typically, to get comfortable that an MSC proof is adequate, you'd want to see the code.

@turt2live
Copy link
Member

fwiw, the SCT only realistically needs access to the feature/implementation in order to test it. This may mean source availability, or it could be creating an account to poke at the APIs and feature. In some cases, it may just mean hanging it off the internet for poking with curl.

@Johennes
Copy link
Contributor

[...] which apparently we did already with an MSC from Beeper [...]

For reference, this happened here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An idea/future MSC for the spec
Projects
None yet
Development

No branches or pull requests

3 participants