Review comments

synapse/config/federation.py

@@ -69,11 +69,8 @@ def read_config(self, config: JsonDict, **kwargs: Any) -> None:
         # when trying to reach an unavailable destination.
         # Unlike previous configuration those values applies across
         # multiple requests and the state of the backoff is stored on DB.
-        self.destination_min_retry_interval_ms = min(
-            Config.parse_duration(
-                federation_config.get("destination_min_retry_interval", "10m")
-            ),
-            2**62,
+        self.destination_min_retry_interval_ms = Config.parse_duration(
+            federation_config.get("destination_min_retry_interval", "10m")
         )
         self.destination_retry_multiplier = federation_config.get(
             "destination_retry_multiplier", 2
@@ -82,6 +79,7 @@ def read_config(self, config: JsonDict, **kwargs: Any) -> None:
             Config.parse_duration(
                 federation_config.get("destination_max_retry_interval", "7d")
             ),
+            # Set a hard-limit to not overflow the database column.
             2**62,
         )