Apply missed suggestions from the review of #16090. (#16263)

* Suggestions from PR * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
matrix-org · Sep 6, 2023 · 5130303 · 5130303
1 parent 35934b0
commit 5130303
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/changelog.d/16263.misc b/changelog.d/16263.misc
@@ -0,0 +1 @@
+Add GCC and GNU Make to the Nix flake development environment so that `ruff` can be compiled.
diff --git a/flake.nix b/flake.nix
@@ -89,6 +89,7 @@
                   })
                   # The rust-analyzer language server implementation.
                   rust-analyzer
+
                   # GCC includes a linker; needed for building `ruff`
                   gcc
                   # Needed for building `ruff`
@@ -248,8 +249,8 @@
                 # that the development environment's cc compiler uses may differ from that of the system.
                 #
                 # When LD_LIBRARY_PATH is set, system tools will attempt to use the development environment's
-                # libraries. Which, when built against an different glibc version lead, to "version 'GLIBC_X.YY' not
-                # found" errors.
+                # libraries. Which, when built against a different glibc version lead, to "version 'GLIBC_X.YY'
+                # not found" errors.
                 enterShell = ''
                   unset LD_LIBRARY_PATH
                 '';