Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Wrong type for /publicRooms limit #10304

Open
timokoesters opened this issue Jul 2, 2021 · 1 comment
Open

Wrong type for /publicRooms limit #10304

timokoesters opened this issue Jul 2, 2021 · 1 comment
Labels
A-Room-Directory A-Spec-Compliance places where synapse does not conform to the spec P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@timokoesters
Copy link

timokoesters commented Jul 2, 2021 •
edited
Loading

According to https://spec.matrix.org/unstable/server-server-api/#get_matrixfederationv1publicrooms it should be an integer, but here it is stringified:

synapse/synapse/federation/transport/client.py

Line 425 in a7a3743

data["limit"] = str(limit)

Conduit errors when the parameter is a string.
@babolivier babolivier added P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jul 2, 2021
@reivilibre
Copy link
Contributor

Note that there are two issues here:

  1. that Synapse sends strings against the spec
  2. that Synapse accepts strings (i.e. doesn't enforce the spec).

Fixing the first should be easy; fixing the second probably wants some lenience to allow other Synapse servers to upgrade.

@reivilibre reivilibre mentioned this issue Apr 4, 2022
Merged
@MadLittleMods MadLittleMods added A-Room-Directory A-Spec-Compliance places where synapse does not conform to the spec labels Jun 30, 2023
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Room-Directory A-Spec-Compliance places where synapse does not conform to the spec P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MadLittleMods @babolivier @timokoesters @reivilibre