This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Implement MSC4072: return result for all /keys/claims #16579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't know for certain that keys will be `JsonDict`s -- indeed if the key is not signed it will just be a string. Fix up the types to reflect this.
Rather than making the caller merge the results together, do it inside `claim_local_one_time_keys`.
`set_tag` isn't really appropriate here, since we're logging an entire dict rather than something useful to search on. (Also, it will get truncated.) Use `log_kv` instead.
richvdh
force-pushed
the
rav/out_of_keys_claims
branch
from
34d53fe
to
9347b96
Compare
|
I decided to handle this on the client side in the end (matrix-org/matrix-rust-sdk#2805) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC4072 says we should return a result for all requested devices in a
/keys/claimrequest. Here's an impl.With some preparatory refactoring and cleanup.