Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify status of backup implementation #155

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

Johennes
Copy link
Contributor

In a chat with @ara4n yesterday I learnt that the legacy backup has actually been implemented in matrix-sdk-crypto and isn't planned to be added here anymore. I suppose MSC4048 will be implemented there, too, then which is why I have removed its reference as well.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (4ef989c) to head (7b3e5f7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files          34       34           
  Lines        1908     1908           
=======================================
  Hits         1728     1728           
  Misses        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkasak
Copy link
Member

dkasak commented May 17, 2024

We avoided implementing primitives for the existing backup in vodozemac because the design is known to be flawed. Therefore, in my opinion it's not a given that none of the improved design (MSC4048) will end up in vodozemac. The deciding factor for that should be whether something is a "primitive" or foundational cryptographic construct, in which case it belongs in vodozemac, or if it is more of a Matrix layer feature, in which case it should be part of matrix-sdk-crypto.

README.md Show resolved Hide resolved
Co-authored-by: Denis Kasak <dkasak@termina.org.uk>
@Johennes
Copy link
Contributor Author

Ah, I see. Thanks for clarifying.

@dkasak dkasak self-requested a review May 17, 2024 11:01
@dkasak dkasak enabled auto-merge May 17, 2024 11:01
@dkasak dkasak merged commit f0a897b into matrix-org:main May 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants