Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@wsdewitt raised the concern of our low-rank approximation code not playing well with our gauge-fixing procedures (spoiler: he was right). I've gone ahead and written some tests for this (that fail as expected). I figured I'd spend some time thinking about this and if there's any workaround -- though I'm in the same boat as Will right now in thinking these two things may not be able to play together. Will leave this up though until we can discuss it.
I've also revamped how this truncated-SVD/low-rank approximation is implemented, moving things from
analysis.py
over tomodel.py
as suggested.Closes #132
Tests
Updated test for low-rank approximations on
FullyConnected
andEscape
models.A test to see if gauge-fixing and truncated-SVD play nicely together -- expected to fail, does fail.
Checklist:
#278
) has been searched for in the code to find relevant notes