Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand list of gems to install to work around conservative update #1

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

mattbrictson
Copy link
Owner

Some gems are "meta gems" that are composed of other gems locked at identical versions. For example, rails 7.0.4.3 requires activesupport =7.0.4.3, railties =7.0.4.3, and so on.

Therefore, running bundle update --conservative rails may not work depending on how strictly Bundler enforces "conservative" (this behavior is also slightly different in different Bundler releases). In this case, you might see a message from Bundler like:

Attempted to update rails, but the version stayed the same

With this commit, update-interactive solves this problem by updating the entire suite of gems when a "meta gem" is selected for update. In other words, if you pick rails from the list of gems to update, update-interactive will automatically include activesupport, railies, etc. as well, ensuring that the update is successful.

Some gems are "meta gems" that are composed of other gems locked at
identical versions. For example, rails 7.0.4.3 requires activesupport
=7.0.4.3, railties =7.0.4.3, and so on.

Therefore, running `bundle update --conservative rails` may not work
depending on how strictly Bundler enforces "conservative" (this behavior
is also slightly different in different Bundler releases). In this case,
you might see a message from Bundler like:

> Attempted to update rails, but the version stayed the same

With this commit, `update-interactive` solves this problem by updating
the entire suite of gems when a "meta gem" is selected for update. In
other words, if you pick rails from the list of gems to update,
`update-interactive` will automatically include activesupport, railies,
etc. as well, ensure that the update is successful.
@mattbrictson mattbrictson added 🐛 Bug Fix Fixes a bug automerge Automatically merge PR once all required checks pass labels Jul 11, 2024
@kodiakhq kodiakhq bot merged commit 4b3ebf3 into main Jul 11, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the feature/expand-gems branch July 11, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all required checks pass 🐛 Bug Fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant