Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle non-GitHub git sources when inferring changelog URI #6

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

mattbrictson
Copy link
Owner

When a gem was sourced from a Git repository other than GitHub, update-interactive would build a malformed GitHub changelog URL. Fix the logic bug that caused this, and fall back to Gem::Specification#homepage for Git-sourced gems that come from non-GitHub repositories.

@mattbrictson mattbrictson added the 🐛 Bug Fix Fixes a bug label Jul 15, 2024
@mattbrictson mattbrictson merged commit e95c6f6 into main Jul 15, 2024
8 checks passed
@mattbrictson mattbrictson deleted the fix-git-changelog branch July 15, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant