feat: add new zksync-llvm-runner with llvm18 support #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbaliasnikov
force-pushed
the
aba-ubuntu22-llvm18
branch
3 times, most recently
from
3cc2bd7
to
84c38dc
Compare
antonbaliasnikov
changed the title
antonbaliasnikov
force-pushed
the
aba-ubuntu22-llvm18
branch
from
84c38dc
to
69bcae5
Compare
hedgar2017
approved these changes
Aug 7, 2024
This was referenced Aug 9, 2024
hedgar2017
pushed a commit
to matter-labs/era-compiler-ci
that referenced
this pull request
Aug 9, 2024
# What ❔ Use new `zksync-llvm-runner` package from github registry introduced in matter-labs/compiler-infra#84. <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ To stabilize docker updates. <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR. - [x] Documentation comments have been added / updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
zksync-llvm-runnerpackage with updated CIlatestavailablePurpose
Images will continue to support
latestnotion, but at the same time we introduce semver for them to be able to properly test and switch to the new versions without breaking any workflows. When the new image is released, it will be tagged asmainallowing to perform testing in CI repository. After the testing is successful, we can tag it andlatestwill be automatically updated distributing the changes without the need of updating any CI workflows.At the same time, we will update host LLVM to be compatible with the LLVM we're using in Rust to solve all kinds of the binary conflicts when re-using some LLVM features between C++ and Rust like code coverage instrumentation.