Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the broken --version endpoint #115

Conversation

hedgar2017
Copy link
Collaborator

@hedgar2017 hedgar2017 commented Oct 16, 2024

What ❔

Fixes the broken zkvyper --version endpoint.

Why ❔

It was regressed after more argument validations were added.

Checklist

  • PR title corresponds to the body of PR.
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.75%. Comparing base (ae0a22b) to head (380c837).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   64.49%   64.75%   +0.26%     
==========================================
  Files          55       55              
  Lines        4413     4415       +2     
==========================================
+ Hits         2846     2859      +13     
+ Misses       1567     1556      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hedgar2017 hedgar2017 force-pushed the az-cpr-1823-zkvyper-155-returns-non-zero-exit-status-when-checking-for branch from faedbd3 to 111b35a Compare October 16, 2024 14:19
src/zkvyper/arguments.rs Show resolved Hide resolved
@hedgar2017 hedgar2017 force-pushed the az-cpr-1823-zkvyper-155-returns-non-zero-exit-status-when-checking-for branch from 111b35a to 380c837 Compare October 16, 2024 15:35
[skip ci]
@hedgar2017 hedgar2017 force-pushed the az-cpr-1823-zkvyper-155-returns-non-zero-exit-status-when-checking-for branch from 380c837 to 1b582e3 Compare October 16, 2024 15:46
@hedgar2017 hedgar2017 merged commit be758e3 into main Oct 16, 2024
@hedgar2017 hedgar2017 deleted the az-cpr-1823-zkvyper-155-returns-non-zero-exit-status-when-checking-for branch October 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants