chore: synchronise linting rules of repositories #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
benceharomi
changed the title
benceharomi
requested review from
vladbochok and
StanislavBreadless
as code owners
…erlabs/prettier-config
…labs/prettier-config
…-linting-rules-of-repositories # Conflicts: # ethereum/package.json
This reverts commit 5fb5915.
StanislavBreadless
approved these changes
Nov 2, 2023
StanislavBreadless
deleted the
bh-evm-294-synchronise-linting-rules-of-repositories
branch
benceharomi
pushed a commit
that referenced
this pull request
Nov 17, 2023
…bel-external-contributions ci: add workflow to label external-contributions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Synchronise the linting and formatting rules of the repositories, use the configs from the
era-system-contractsrepository as a base.Steps:
ethereumdirzksyncdirera-system-contractszksynclinting to the CISimplified/standardised the way of calling the linting/formatting commands, see: matter-labs/era-system-contracts#49
Added
pre-commitandpre-pushhooks to check formatting/linting automatically with PR #75Why ❔
Currently the
era-contractsand theera-system-contractsrepositories have different linting and formatting rules, the goal of this task is to synchronise them.Checklist
Tests for the changes have been added / updated.