Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Testing framework for bootloader #14

Merged
merged 30 commits into from
Oct 10, 2023
Merged

Testing framework for bootloader #14

merged 30 commits into from
Oct 10, 2023

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Sep 14, 2023 •
edited
Loading

What

  • Unittests for the bootloader with the required infrastructure

Why

  • we need to improve the testing coverage of our most important contracts
  • tests should be as close to the contract as possible, rather than in a separate repo, like it is today.

image

@mm-zk mm-zk marked this pull request as ready for review September 18, 2023 12:58
@mm-zk mm-zk requested a review from AntonD3 September 18, 2023 12:58
mm-zk
mm-zk commented Sep 18, 2023
View reviewed changes
scripts/compile-yul.ts Outdated Show resolved Hide resolved
StanislavBreadless
StanislavBreadless reviewed Sep 19, 2023
View reviewed changes
bootloader/test_infra/Cargo.toml Outdated Show resolved Hide resolved
bootloader/test_infra/src/main.rs Outdated Show resolved Hide resolved
bootloader/test_infra/src/main.rs Outdated Show resolved Hide resolved
bootloader/test_infra/src/main.rs Outdated Show resolved Hide resolved
bootloader/test_infra/src/main.rs Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
scripts/process.ts Outdated Show resolved Hide resolved
scripts/process.ts Outdated Show resolved Hide resolved
scripts/process.ts Outdated Show resolved Hide resolved
bootloader/bootloader.yul Show resolved Hide resolved
AntonD3
AntonD3 reviewed Sep 20, 2023
View reviewed changes
scripts/process.ts Show resolved Hide resolved
scripts/process.ts Show resolved Hide resolved
bootloader/test_infra/README.md Outdated Show resolved Hide resolved
StanislavBreadless
StanislavBreadless previously approved these changes Sep 20, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@mm-zk mm-zk changed the base branch from main to dev October 6, 2023 09:21
StanislavBreadless
StanislavBreadless approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@StanislavBreadless StanislavBreadless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I left only a few nits

bootloader/test_infra/Cargo.toml Outdated Show resolved Hide resolved
scripts/process.ts Show resolved Hide resolved
bootloader/test_infra/src/main.rs Show resolved Hide resolved
bootloader/test_infra/src/main.rs Outdated Show resolved Hide resolved
bootloader/test_infra/src/main.rs Outdated Show resolved Hide resolved
@mm-zk mm-zk merged commit 1d18d2e into dev Oct 10, 2023
6 checks passed
@mm-zk mm-zk deleted the 0914_poc_bootloader_tests branch October 10, 2023 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

@vladbochok vladbochok Awaiting requested review from vladbochok vladbochok is a code owner

@AntonD3 AntonD3 Awaiting requested review from AntonD3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mm-zk @StanislavBreadless @AntonD3