This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Integration of optimized keccak precompile #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vladbochok
approved these changes
Oct 13, 2023
StanislavBreadless
changed the title
|
Btw, right now in order to preprocess the bootloader you need to build the Keccak256, it depends on the bytecode hash. And the |
* Zero ptr keccak test * Update contracts/test-contracts/KeccakTest.sol Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com> --------- Co-authored-by: Stanislav Bezkorovainyi <stanislavbezkor@gmail.com> Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
vladbochok
reviewed
Oct 23, 2023
vladbochok
approved these changes
Oct 23, 2023
Fix incorrect calculation for required number of keccak256 hash rounds
Reorder getter functions in the Bootloader
Better tests for keccak precompile
Add comments for keccak256 wrapper
Add missing Comments for temporary functions in Bootloader and ContractDeployer
Add constructor code
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
Remove outdated comment
fix typos
* fix misleading comment * fix lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Integration of the optimized Keccak256 precompile together with the migration to it.
Why ❔
Checklist
zk fmtandzk lint.