Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

chore: synchronise linting rules of repositories #49

Merged

Conversation

benceharomi
Copy link
Contributor

@benceharomi benceharomi commented Oct 24, 2023

What ❔

Simplified/standardised the way of calling the linting/formatting commands for checking/fixing the rules in the repositories:

  • yarn prettier:check -> check formatting
  • yarn prettier:fix -> formats the files with incorrect format
  • yarn lint:check -> checks the rules and formatting
  • yarn lint:fix -> fixes the rules and formatting (modifies the files and fixes the automatically fixable errors)

Also added these options to the calculate-hashes command:

  • yarn calculate-hashes:check -> calculates the hashes and compares them to the SystemContractsHashes.json
  • yarn calculate-hashes:fix -> calculates the hashes and updates the SystemContractsHashes.json

Added pre-commit and pre-push hooks to check formatting/linting automatically with PR #56

Why ❔

Currently the era-contracts and the era-system-contracts repositories have different linting and formatting rules, the goal of this task is to synchronise them.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@benceharomi benceharomi changed the title lint: synchronise linting rules of repositories chore: synchronise linting rules of repositories Oct 25, 2023
@StanislavBreadless StanislavBreadless merged commit 27d550a into dev Nov 2, 2023
8 checks passed
@StanislavBreadless StanislavBreadless deleted the bh-evm-294-synchronise-linting-rules-of-repositories branch November 2, 2023 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants