This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
chore: synchronise linting rules of repositories #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Simplified/standardised the way of calling the linting/formatting commands for checking/fixing the rules in the repositories:
yarn prettier:check
-> check formattingyarn prettier:fix
-> formats the files with incorrect formatyarn lint:check
-> checks the rules and formattingyarn lint:fix
-> fixes the rules and formatting (modifies the files and fixes the automatically fixable errors)Also added these options to the
calculate-hashes
command:yarn calculate-hashes:check
-> calculates the hashes and compares them to theSystemContractsHashes.json
yarn calculate-hashes:fix
-> calculates the hashes and updates theSystemContractsHashes.json
Added
pre-commit
andpre-push
hooks to check formatting/linting automatically with PR #56Why ❔
Currently the
era-contracts
and theera-system-contracts
repositories have different linting and formatting rules, the goal of this task is to synchronise them.Checklist
Tests for the changes have been added / updated.