This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 106
updated hh version and solidity version #52
Merged
koloz193
merged 10 commits into
release-v18-boojum
from
zk-evm-351-update-solidity-version
Oct 31, 2023
Merged
updated hh version and solidity version #52
koloz193
merged 10 commits into
release-v18-boojum
from
zk-evm-351-update-solidity-version
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koloz193
requested review from
StanislavBreadless and
vladbochok
as code owners
October 30, 2023 14:07
benceharomi
reviewed
Oct 30, 2023
vladbochok
reviewed
Oct 30, 2023
StanislavBreadless
approved these changes
Oct 31, 2023
benceharomi
approved these changes
Oct 31, 2023
vladbochok
suggested changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the version here too.
benceharomi
approved these changes
Oct 31, 2023
vladbochok
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Updating the hardhat version and solidity compiler versions.
Why ❔
There was a bug found in earlier solidity versions known to have a bug in the legacy code generation pipeline,
MissingSideEffectsOnSelectorAccess
.Checklist
zk fmt
andzk lint
.