Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Set of fixes for boojum integration #53

Merged
merged 34 commits into from
Nov 1, 2023
Merged

Set of fixes for boojum integration #53

merged 34 commits into from
Nov 1, 2023

Conversation

StanislavBreadless
Copy link
Collaborator

What ❔

  • Fix max system contract address
  • Ensure that only deployments are allowed for L1->L2 transactions
  • Fix for L1Messenger
  • Fix the EIP1559 checks
  • Fix charging for memory overhead
  • Fix EOA for delegatecalls
  • Add forceDeploy for keccak256 for future use
  • Ensure
  • Lots of other comments/minor changes

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@StanislavBreadless
apply max system contracts address
934d8cd
@StanislavBreadless
add comment
03ae0fe
@StanislavBreadless
Allow only deployments for L1->L2
1ded147
@StanislavBreadless
fail to publish timesstamp
dc0aa8f
@StanislavBreadless
remove trailing comma
ff69c5c
@StanislavBreadless
correct require for L1Messenger
4939acc
@StanislavBreadless
fix eip1559
ff73f7c
@StanislavBreadless
charge correctly for the memory overhead
015fa52
@StanislavBreadless
check that we have enough gas for postop
e05bb21
@StanislavBreadless
fix comment in L1Messenger
abd65b9
@StanislavBreadless
remove redundant check
53b6d58
@StanislavBreadless
safeAdd for refunds
479ab08
@StanislavBreadless
compilation fixes + EOA work correctly on delegatecall
1f89a6b
@StanislavBreadless
correctly charge for gas overhead
2d479d4
@StanislavBreadless
ensure that upgrade tx always succeeds
5487915
@StanislavBreadless
add force deploy for keccak256
963c5e0
@StanislavBreadless
max precompile address fix
1449d37
@StanislavBreadless
correct refund gas for L1 gas
d2103a5
@StanislavBreadless
fix shifting
700f380
@StanislavBreadless
correct meta calculation
70f6ee4
@StanislavBreadless
nits
28718b1
@StanislavBreadless
prev hash
b48fc2b
@StanislavBreadless
fix some nits
e5400cf
@StanislavBreadless
remove unneeded casting
2027a2c
@StanislavBreadless StanislavBreadless requested review from vladbochok and koloz193 and removed request for vladbochok October 30, 2023 23:00
@StanislavBreadless StanislavBreadless changed the base branch from dev to release-v18-boojum October 31, 2023 10:45
vladbochok
vladbochok reviewed Oct 31, 2023
View reviewed changes
contracts/NonceHolder.sol Outdated Show resolved Hide resolved
contracts/Constants.sol Outdated Show resolved Hide resolved
vladbochok
vladbochok reviewed Oct 31, 2023
View reviewed changes
contracts/Constants.sol Outdated Show resolved Hide resolved
@StanislavBreadless @vladbochok
Update bootloader/bootloader.yul
59b26b3 
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
@StanislavBreadless StanislavBreadless merged commit 8a4349e into release-v18-boojum Nov 1, 2023
8 checks passed
@StanislavBreadless StanislavBreadless deleted the sb-boojum-integration-patch branch November 1, 2023 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nateawelch nateawelch nateawelch approved these changes

@koloz193 koloz193 koloz193 approved these changes

@vladbochok vladbochok vladbochok approved these changes

@benceharomi benceharomi benceharomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StanislavBreadless @nateawelch @koloz193 @vladbochok @benceharomi