This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
chore: create githooks to check formatting and linting #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benceharomi
requested review from
StanislavBreadless and
vladbochok
as code owners
benceharomi
changed the title
benceharomi
merged commit 41f51f9
into
bh-evm-294-synchronise-linting-rules-of-repositories
8 checks passed
benceharomi
deleted the
bh-evm-314-create-githooks-to-check-formatting-and-linting
branch
3 tasks
StanislavBreadless
pushed a commit
that referenced
this pull request
Nov 2, 2023
* chore: command name changes * lint(calculate-hashes): fix * fix: lint:md command * chore: package.json commands alphabetical order * lint: using @matterlabs/eslint-config-typescript and "@matterlabs/prettier-config * style: prettier:fix * lint: lint:fix * Revert "lint: lint:fix" This reverts commit 15993b2. * lint: eslint rules turned off * lint: lint:fix with new rules * chore: .eslintignore removed * chore: create githooks to check formatting and linting (#56) * chore: pre-commit and pre-push hooks added * docs: removed yarn lint from PR template * Revert "chore: package.json commands alphabetical order" This reverts commit e39a52c.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Create
pre-commitandpre-pushgithooks for the era-contracts and era-system-contracts repositories.Steps:
pre-commithook that runs theprettier:checkcommand to prohibit committing unformatted codepre-pushhook that runs thelint:checkcommand to prohibit pushing unlinted codeethereumandzksyncdirectories.githooksdirectory.githooks:git config core.hooksPath .githooks/pre-commitandpre-pushchmod +x fileWhy ❔
Currently, the formatting and linting has to be run manually, that can be easily forgotten, create githooks that run these automatically!
Checklist
Tests for the changes have been added / updated.