Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Fix incorrect calculation for required number of keccak256 hash rounds #63

Merged

Conversation

vladbochok
Copy link
Member

What ❔

Increase the number of hash rounds in the gas calculation per keccak256 precompile call.

Why ❔

The number of rounds required to compute hash was incorrect for data multiples of 136.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@StanislavBreadless StanislavBreadless merged commit bc495d0 into v1-4-1-integration Nov 21, 2023
5 of 6 checks passed
@StanislavBreadless StanislavBreadless deleted the vb-fix-oz-keccak256-audit-n-04 branch November 21, 2023 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants