Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Testing infrastructure improvements #82

Merged
merged 38 commits into from
Dec 11, 2023
Merged

Testing infrastructure improvements #82

merged 38 commits into from
Dec 11, 2023

Conversation

AntonD3
Copy link
Contributor

@AntonD3 AntonD3 commented Dec 5, 2023

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@AntonD3 AntonD3 marked this pull request as ready for review December 7, 2023 18:45
@AntonD3 AntonD3 requested a review from koloz193 December 7, 2023 19:17
StanislavBreadless
StanislavBreadless reviewed Dec 8, 2023
View reviewed changes
contracts/test-contracts/MockContract.sol Outdated Show resolved Hide resolved
contracts/test-contracts/MockContract.sol Show resolved Hide resolved
contracts/test-contracts/ExtraAbiCaller.zasm Show resolved Hide resolved
scripts/calculate-hashes.ts Outdated Show resolved Hide resolved
scripts/calculate-hashes.ts Outdated Show resolved Hide resolved
StanislavBreadless
StanislavBreadless reviewed Dec 8, 2023
View reviewed changes
test/DefaultAccount.spec.ts Outdated Show resolved Hide resolved
contracts/test-contracts/MockContract.sol Show resolved Hide resolved
test/shared/constants.ts Outdated Show resolved Hide resolved
vladbochok
vladbochok reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@vladbochok vladbochok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure compiler tester will work with new preprocessort

contracts/test-contracts/MockContract.sol Outdated Show resolved Hide resolved
contracts/test-contracts/MockContract.sol Outdated Show resolved Hide resolved
test/shared/constants.ts Outdated Show resolved Hide resolved
@AntonD3 @vladbochok
Update contracts/test-contracts/MockContract.sol
62e1c44 
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
vladbochok
vladbochok reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@vladbochok vladbochok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that tests are state dependent and also EnumerableSet can be used for the mock. Otherwise lgtm

@AntonD3
Copy link
Contributor Author

AntonD3 commented Dec 11, 2023

@vladbochok @StanislavBreadless currently bootloader test infra depends on the https://github.com/matter-labs/zksync-era/tree/ad-update-sc-paths. It's forked from the last commit of the main branch. In the future, we will need to update everything at the same time(system contracts in the server, merge ad-update-sc-paths), and then we can change the branch to the main in the bootloader test infra

@StanislavBreadless StanislavBreadless merged commit 3c6893d into dev Dec 11, 2023
8 checks passed
@StanislavBreadless StanislavBreadless deleted the ad-better-sc-tests branch December 11, 2023 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

@vladbochok vladbochok vladbochok approved these changes

@benceharomi benceharomi Awaiting requested review from benceharomi

@koloz193 koloz193 Awaiting requested review from koloz193

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntonD3 @vladbochok @StanislavBreadless @Deniallugo