Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner detection of out-of-gas situations #239

Closed
mm-zk opened this issue Dec 15, 2023 · 1 comment
Closed

Cleaner detection of out-of-gas situations #239

mm-zk opened this issue Dec 15, 2023 · 1 comment
Labels
feature ➕ Feature item p2 🟡 Indicates moderately high priority item

Comments

@mm-zk
Copy link
Collaborator

mm-zk commented Dec 15, 2023

🌟 Feature Request

📝 Description

Currently, when contract runs out of gas, you can see the 'panic' message, but you don't know the reason. It would be great if we passed the clear information that this was caused by out of gas.

🤔 Rationale

This will make debugging a lot easier.

🖼️ Mockups/Examples

image This should say 'out of gas' instead of 'only' Panic.

📋 Additional Context

You can fetch the panic reason from the error_flags.
Here's the (very dirty) example, how this could work:
8338df6
We should probably move it either into CallTracer - or create a separate tracer just for era test node to catch and print this information.

@dutterbutter dutterbutter added p2 🟡 Indicates moderately high priority item feature ➕ Feature item labels Jan 30, 2024
@MexicanAce
Copy link
Collaborator

Resolved with #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ➕ Feature item p2 🟡 Indicates moderately high priority item
Projects
None yet
Development

No branches or pull requests

3 participants