Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adapting Era test node to the new VM (and updating system contracts) #111

Merged
merged 22 commits into from
Sep 25, 2023
Merged

feat: adapting Era test node to the new VM (and updating system contracts) #111

merged 22 commits into from
Sep 25, 2023

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Sep 13, 2023 •
edited
Loading

What 💻

  • Adapting era-test-node to use the new VM interface
  • re-syncing all the changes to bootloader and system contracts (including virtual blocks)

Why ✋

  • to support newer versions of the blocks

Evidence 📷

image

Notes 📝

  • Most of the code to review is in node.rs
  • CallTraces are unfortunately broken - still investigating
  • seems that the hashes (for example from events) are now printed fully - we should move them back to shorter form

MexicanAce
MexicanAce reviewed Sep 13, 2023
View reviewed changes
src/fork.rs Outdated Show resolved Hide resolved
MexicanAce
MexicanAce reviewed Sep 18, 2023
View reviewed changes
src/formatter.rs Outdated Show resolved Hide resolved
src/formatter.rs Show resolved Hide resolved
src/formatter.rs Show resolved Hide resolved
src/node.rs
fn create_l1_batch_env<ST: ReadStorage>(&self, storage: StoragePtr<ST>) -> L1BatchEnv {
let last_l2_block = load_last_l2_block(storage);
L1BatchEnv {
// TODO: set the previous batch hash properly (take from fork, when forking, and from local storage, when this is not the first block).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we track this in a GitHub Issue and link here?

src/node.rs Outdated Show resolved Hide resolved
src/node.rs Show resolved Hide resolved
src/node.rs Outdated Show resolved Hide resolved
src/node.rs Outdated Show resolved Hide resolved
src/node.rs Show resolved Hide resolved
src/node.rs Show resolved Hide resolved
@MexicanAce MexicanAce mentioned this pull request Sep 20, 2023
Closed
@mm-zk mm-zk changed the title (PoC) - adapting Era test node to the new VM (and updating system contracts) feat: adapting Era test node to the new VM (and updating system contracts) Sep 22, 2023
@mm-zk mm-zk marked this pull request as ready for review September 22, 2023 07:29
@mm-zk mm-zk requested a review from a team as a code owner September 22, 2023 07:29
MexicanAce
MexicanAce reviewed Sep 22, 2023
View reviewed changes
Cargo.lock Show resolved Hide resolved
MexicanAce
MexicanAce approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mm-zk mm-zk merged commit 915b0c0 into main Sep 25, 2023
9 checks passed
@mm-zk mm-zk deleted the 0912_new_vm branch September 25, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mm-zk @MexicanAce