Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl evm_mine and hardhat_mine #116

Merged
merged 10 commits into from
Sep 18, 2023
Merged

feat: impl evm_mine and hardhat_mine #116

merged 10 commits into from
Sep 18, 2023

Conversation

grw-ms
Copy link
Contributor

@grw-ms grw-ms commented Sep 14, 2023 •
edited
Loading

What 💻

  • Adds evm_mine as supported RPC method
  • Adds hardhat_mine as supported RPC method
  • Adds tests/docs

Why ✋

  • Allows user to manually trigger a new block(s) to be mined

Evidence 📷

image
image
image
image

Notes 📝

  • Seems quite a lot of setup for rolling new block

@grw-ms grw-ms requested a review from a team as a code owner September 14, 2023 09:38
MexicanAce
MexicanAce reviewed Sep 14, 2023
View reviewed changes
src/evm.rs Outdated Show resolved Hide resolved
MexicanAce
MexicanAce reviewed Sep 14, 2023
View reviewed changes
src/evm.rs Outdated Show resolved Hide resolved
nbaztec
nbaztec reviewed Sep 14, 2023
View reviewed changes
src/evm.rs Outdated Show resolved Hide resolved
nbaztec
nbaztec reviewed Sep 14, 2023
View reviewed changes
src/evm.rs Outdated Show resolved Hide resolved
@grw-ms grw-ms changed the title feat: impl evm_mine feat: impl evm_mine and hardhat_mine Sep 14, 2023
MexicanAce
MexicanAce reviewed Sep 15, 2023
View reviewed changes
src/evm.rs Outdated Show resolved Hide resolved
src/hardhat.rs Outdated Show resolved Hide resolved
src/utils.rs Outdated Show resolved Hide resolved
src/utils.rs Outdated Show resolved Hide resolved
MexicanAce
MexicanAce approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit 0b73bd3 into matter-labs:main Sep 18, 2023
8 checks passed
@grw-ms grw-ms deleted the grw/impl-evm-mine-v2 branch September 18, 2023 15:51
This was referenced Sep 18, 2023
Closed
Closed
IAvecilla pushed a commit to lambdaclass/era-test-node that referenced this pull request Feb 29, 2024
@jpcenteno @ColoCarletti
Document montgomeryAdd and montgomerySub (matter-labs#116)
062fbcf 
* doc: add missing docstrings for montgomeryAdd and montgomerySub

* Fix links to Montgomery REDC algorithm

---------

Co-authored-by: Joaquin Carletti <56092489+ColoCarletti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbaztec nbaztec nbaztec left review comments

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grw-ms @nbaztec @MexicanAce