Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updated zksync era dependency to v6.0.0 #126

Merged
merged 1 commit into from
Sep 20, 2023
Merged

chore: updated zksync era dependency to v6.0.0 #126

merged 1 commit into from
Sep 20, 2023

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Sep 20, 2023

What 💻

  • Updated the dependency on zksync-era to v6
  • this is basically the same as we use today, so there are no changes.

Why ✋

  • zksync era is doing a major release, that contains a large VM api change
  • so we have to clean up our dependency versions, so that era-test-node doesn't get broken
  • as previous commit of zksync-era that we depended on, have sub-dependencies that will be broken soon

Evidence 📷

image

@mm-zk mm-zk marked this pull request as ready for review September 20, 2023 06:54
@mm-zk mm-zk requested a review from a team as a code owner September 20, 2023 06:54
@mm-zk mm-zk changed the title Updated zksync era dependency to v6.0.0 chore: Updated zksync era dependency to v6.0.0 Sep 20, 2023
MexicanAce
MexicanAce reviewed Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce changed the title chore: Updated zksync era dependency to v6.0.0 chore: updated zksync era dependency to v6.0.0 Sep 20, 2023
@MexicanAce MexicanAce merged commit e2bfc0e into main Sep 20, 2023
10 of 11 checks passed
@MexicanAce MexicanAce deleted the 0920_update_era_deps branch September 20, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

@shahar4 shahar4 shahar4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mm-zk @MexicanAce @shahar4