Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update and add more e2e tests #132

Merged
merged 16 commits into from
Sep 26, 2023
Merged

chore: update and add more e2e tests #132

merged 16 commits into from
Sep 26, 2023

Conversation

MexicanAce
Copy link
Collaborator

@MexicanAce MexicanAce commented Sep 22, 2023 •
edited
Loading

What 💻

  • Add more e2e tests
  • Add lint check for e2e tests
  • Update Cargo.lock with cargo update -p zksync_core
  • Add make run command
  • Update README.md with new installation instructions
  • Add config_getCurrentTimestamp endpoint
  • Update logging middleware to Debug log level
  • Fix genesis block creation

Why ✋

  • These E2E tests are valuable for verification when doing larger upgrades and validation of Hardhat integration/support
  • Linting will ensure code styling standards and reduce nit: PR comments
  • An upstream branch was updated and thus our dependency commit hashes needed to update accordingly
  • Having a make run command simplifies local development
  • Now that we have GitHub Releases with binaries, we should be instructing users to download and use these binaries install of building locally from the cargo crate
  • We need to know the current timestamp of the node for some e2e tests that attempt to manipulate it
  • Incoming requests were becoming too spammy, so moved them to Debug to filter them out by default
  • The initial block for era_test_node run did not have the correct timestamp or hash. Simplified to generate an empty block like the other ones we create.

Evidence 📷

image

@MexicanAce MexicanAce marked this pull request as ready for review September 26, 2023 10:58
@MexicanAce MexicanAce requested a review from a team as a code owner September 26, 2023 10:58
mm-zk
mm-zk previously approved these changes Sep 26, 2023
View reviewed changes
e2e-tests/.prettierrc Show resolved Hide resolved
e2e-tests/test/main.test.ts Outdated Show resolved Hide resolved
e2e-tests/test/hardhat-apis.test.ts Show resolved Hide resolved
e2e-tests/test/evm-apis.test.ts Show resolved Hide resolved
dutterbutter
dutterbutter reviewed Sep 26, 2023
View reviewed changes
e2e-tests/test/main.test.ts
expect(filterChanges[0].transactionHash).to.eq(receipt.transactionHash);
expect(filterChanges[0].blockHash).to.eq(receipt.blockHash);
const eventInterface = new ethers.utils.Interface(["event LogString(string value)"]);
expect(eventInterface.parseLog(filterChanges[0]).args[0]).to.equal("Greeting is being updated to Darth Vader");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@MexicanAce MexicanAce merged commit d96bbba into main Sep 26, 2023
9 checks passed
@MexicanAce MexicanAce deleted the nmv/update-e2e-tests branch September 26, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

@mm-zk mm-zk mm-zk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MexicanAce @dutterbutter @mm-zk