Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates readme, adds templates, updates makefile, and adds CI #18

Merged
merged 9 commits into from
Jul 26, 2023

Conversation

dutterbutter
Copy link
Collaborator

@dutterbutter dutterbutter commented Jul 24, 2023

What 💻

  • Updated the README.md
  • Adds templates for issues
  • Added CONTRIBUTING.md
  • Added CODEOWNERS
  • Added CI checks for linting, tests, build, and secret scanner
  • Adds single unit test for demonstration and CI
  • Updates makefile

Note: Clippy is currently set to ignore unwrap() but we will update once we handle errors more gracefully.

Why ✋

  • Step towards standardizing repos, these changes adds necessary structure and controls. The templates, readme, and contributing file are certainly opinionated so please feel free to add suggested changes.

Evidence 📷

Notes 📝

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

Copy link
Contributor

@idea404 idea404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion to adding macos to the test OS set as some would be developing on it

.github/workflows/tests.yaml Outdated Show resolved Hide resolved
@dutterbutter dutterbutter merged commit f5db37f into main Jul 26, 2023
6 checks passed
@MexicanAce MexicanAce deleted the db/update-readme branch August 1, 2023 13:53
IAvecilla pushed a commit to lambdaclass/era-test-node that referenced this pull request Feb 29, 2024
* Add submodules

* Update submodules

* Add Makefile

* Update submodule branch

* Update precompiles

* Update Makefile

- build: updates the submodules if they were already initialized, if not, they are initialized. Then it copies the precompiles directory containing the in-development precompiles to the precompiles directory in the era-test-node submodule. Finally, it build the contracts of the era-test-node.

- run: copies the precompiles directory containing the in-development precompiles to the precompiles directory in the era-test-node submodule. Finally, it build the precompiles of the era-test-node (skipping compiling the contracts again).

* Rename directive

* Update README.md

* Add test directive for running the test suite

* Update README.md

* Add CI

* Update CI

* Remove submodule

* Add Lambda's era-test-node fork as submodule

* Update .gitmodules

* Update era-test-node submodule

* Update modexp version

* Run node in background

* Fix compile & lint jobs

* Fix compile & lint jobs

* Fix CI

* Fix CI

* Revert "Fix CI"

This reverts commit beed98e1c5aa7a9fda57cc2cf51d797ebde30559.

* Update ci.yaml

* Update ci.yaml

* Add projective coordinates optimization for `ecMul` (matter-labs#19)

* Remove test job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants