-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates readme, adds templates, updates makefile, and adds CI #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idea404
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion to adding macos to the test OS set as some would be developing on it
Co-authored-by: Dennis <10233439+idea404@users.noreply.github.com>
IAvecilla
pushed a commit
to lambdaclass/era-test-node
that referenced
this pull request
Feb 29, 2024
* Add submodules * Update submodules * Add Makefile * Update submodule branch * Update precompiles * Update Makefile - build: updates the submodules if they were already initialized, if not, they are initialized. Then it copies the precompiles directory containing the in-development precompiles to the precompiles directory in the era-test-node submodule. Finally, it build the contracts of the era-test-node. - run: copies the precompiles directory containing the in-development precompiles to the precompiles directory in the era-test-node submodule. Finally, it build the precompiles of the era-test-node (skipping compiling the contracts again). * Rename directive * Update README.md * Add test directive for running the test suite * Update README.md * Add CI * Update CI * Remove submodule * Add Lambda's era-test-node fork as submodule * Update .gitmodules * Update era-test-node submodule * Update modexp version * Run node in background * Fix compile & lint jobs * Fix compile & lint jobs * Fix CI * Fix CI * Revert "Fix CI" This reverts commit beed98e1c5aa7a9fda57cc2cf51d797ebde30559. * Update ci.yaml * Update ci.yaml * Add projective coordinates optimization for `ecMul` (matter-labs#19) * Remove test job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Note: Clippy is currently set to ignore
unwrap()
but we will update once we handle errors more gracefully.Why ✋
Evidence 📷
Notes 📝