Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update run with dynamic fee params #377

Merged
merged 10 commits into from
Nov 11, 2024

Conversation

dutterbutter
Copy link
Collaborator

@dutterbutter dutterbutter commented Nov 5, 2024

What 💻

  • Updated default gas price constants for L1, L2, and fair pubdata price in src/config/mod.rs.
  • Added support for offline mode in the CLI, disabling network requests and using default fee parameters. Included an improved warning message to guide users in overriding values via config.toml and --config flag in src/config/cli.rs and src/main.rs.
  • Updated test assertions in e2e-tests/test/zks-apis.test.ts, src/node/eth.rs, and src/node/zks.rs to reflect new gas limit and fee values.

Why ✋

  • Improved gas estimation accuracy, aligning with network requirements and fee model expectations.
  • Enabled offline mode to support scenarios where network access is unavailable or restricted, ensuring graceful fallback to default values.
  • Enhanced test cases to align with new gas limit configurations and ensure accuracy in fee model assertions.

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Closes #347

@dutterbutter dutterbutter marked this pull request as ready for review November 6, 2024 18:15
@dutterbutter dutterbutter requested a review from a team as a code owner November 6, 2024 18:15
@dutterbutter
Copy link
Collaborator Author

dutterbutter commented Nov 6, 2024

I dont think this is the best approach and likely still need improvements re: #365 but for the short-term provides users with accurate gas estimations during default run operation.

@dutterbutter dutterbutter force-pushed the db/update-scaled-factors-gas-estimate branch from f528a42 to 68cd765 Compare November 8, 2024 19:39
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit 2cece10 into main Nov 11, 2024
10 checks passed
@MexicanAce MexicanAce deleted the db/update-scaled-factors-gas-estimate branch November 11, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gas estimation error while deploying smart accounts using default node
2 participants