-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and improvements #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Verification Evidence to the PR description for all changes. Also, I think this resolved 2 of the open GitHub Issues, so let's tag them in the Notes section of the PR description as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What 💻
eth_getCode
eth_call
eth_estimateGas
effective_gas_price
in theeth_getTransactionReceipt
Why ✋
eth_code
was returningcodehash
, not the code, it was fixedeth_call
should be returned to be compatible with the testing toolseth_estimateGas
was updated, to be compatible as welleffective_gas_price
was usedEvidence 📷
Here is an example where error data is used by a tooling
Here is -
revert
word in the error body/messageBEFORE and AFTER of
eth_code
request:Before:
After:
Notes 📝