Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolves #90 | fixes release executable and headers issue #95

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

dutterbutter
Copy link
Collaborator

@dutterbutter dutterbutter commented Sep 5, 2023

What πŸ’»

  • Installs cross from source
  • Adds req deps to Cross.toml and Cargo.toml

Why βœ‹

  • Installing cross from source provides newest image for x86_64-unknown-linux-gnu
  • Updated Cross.toml to include new required deps from rocksdb version update to 0.21.0
  • Adds openssl-sys vendored copy so binary can be distributed with openssl so it can be executable without installing additional deps

Evidence πŸ“·

Release pipeline succeeding from fork:
CleanShot 2023-09-05 at 17 08 32@2x

x86_64-unknown-linux-gnu libraries available:
CleanShot 2023-09-05 at 17 08 52@2x

Notes πŸ“

Closes #90

* Installs cross from source
* Adds req deps to cross.toml and cargo.toml
@dutterbutter dutterbutter added the needs review πŸ‘“ PR requires a review label Sep 5, 2023
@dutterbutter dutterbutter marked this pull request as ready for review September 5, 2023 22:32
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit 3041b7c into main Sep 6, 2023
8 checks passed
@MexicanAce MexicanAce deleted the db/fix#90 branch September 6, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review πŸ‘“ PR requires a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to execute release binaries on 'ubuntu-latest'
2 participants