Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: synchronise linting rules of repositories #312

Conversation

benceharomi
Copy link
Contributor

@benceharomi benceharomi commented Oct 25, 2023

!!! Submodules must be updated before merge !!!

The following PRs are a requirement for these changes to work:
matter-labs/era-contracts#66
matter-labs/era-system-contracts#49

What ❔

Updated format and lint process of the contracts and system-contracts submodules. From now on the formatting and linting commands of the main repository ignores the submodules' files, and calls their format and linting commands instead.

Why ❔

Currently the era-contracts and the era-system-contracts repositories have different linting and formatting rules, the goal of this task is to synchronise them.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@benceharomi benceharomi changed the title lint: synchronise linting rules of repositories chore: synchronise linting rules of repositories Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (222ae96) 32.89% compared to head (2639834) 35.62%.
Report is 6 commits behind head on boojum-integration.

❗ Current head 2639834 differs from pull request most recent head 27f76f0. Consider uploading reports for the commit 27f76f0 to get more accurate results

Additional details and impacted files
@@                  Coverage Diff                   @@
##           boojum-integration     #312      +/-   ##
======================================================
+ Coverage               32.89%   35.62%   +2.72%     
======================================================
  Files                     528      520       -8     
  Lines                   28220    28352     +132     
======================================================
+ Hits                     9284    10099     +815     
+ Misses                  18936    18253     -683     

see 260 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benceharomi benceharomi changed the base branch from main to boojum-integration November 2, 2023 13:58
@benceharomi
Copy link
Contributor Author

changes added to #376

@benceharomi benceharomi closed this Nov 3, 2023
@benceharomi benceharomi deleted the bh-evm-294-synchronise-linting-rules-of-repositories branch November 3, 2023 10:00
toni-calvin pushed a commit to lambdaclass/zksync-era that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant