Adding dialog errors when requests fail in interactive dialogs, fix panics and add consistency to logs #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmartingr
approved these changes
Sep 19, 2024
wiggin77
reviewed
Oct 2, 2024
wiggin77
reviewed
Oct 2, 2024
wiggin77
reviewed
Oct 2, 2024
wiggin77
requested changes
Oct 2, 2024
I think I caught everything now |
wiggin77
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Errors from the plugin were not being surfaced to dialogs so if something went wrong there was no info for the user. I also fixed some potential panics.
Example of dialog error:
Ticket
#19