Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File creation cleanup #23

Merged
merged 6 commits into from
Oct 17, 2024
Merged

File creation cleanup #23

merged 6 commits into from
Oct 17, 2024

Conversation

BenCookie95
Copy link
Contributor

Summary

  • Hide sharing with "anyone" if your organisation has that permission disabled. I searched everywhere but I could not find a way to check this with the v3 SDK, they removed the DomainSharingPolicy field from the about endpoint. The approach to this permission in v3 seems to be that it will tell you if you don't have that permission if you try to apply it to a file, you cannot check beforehand. v2 has the field we need so I decided to use that SDK for that one check. v2 is not deprecated so I think it's safe to use this one time.
  • When sharing a file with channel members it's possible that it will fail to share with some users if they are outside your domain but it should not cause the whole function to fail. I fixed that logic so that we inform the file creator, through a DM, about who didn't gain access.
  • Better dialog error messages when file creation fails at a certain step.

Tickets

#2
#1

Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/plugin/create.go Outdated Show resolved Hide resolved
server/plugin/create.go Outdated Show resolved Hide resolved
BenCookie95 and others added 2 commits October 3, 2024 13:47
Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>
Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>
Base automatically changed from interactive-dialog-errors to master October 17, 2024 21:01
@wiggin77 wiggin77 merged commit 8229695 into master Oct 17, 2024
4 checks passed
@wiggin77 wiggin77 deleted the file-creation-fixes branch October 17, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants