feat(e2e): Verify Test Notification on Desktop #3162

yasserfaraazkhan · 2024-10-08T13:31:37Z

Fixed the windows job getting skipped in master branch
Added Test to check Notification Badge on the task Bar on MacOS. (there's not method in electron api that supports windows & linux)

Waiting on Dev PR to merge: mattermost/mattermost#28334

NONE

github-actions · 2024-10-08T14:06:04Z

Here are the test results below:

Test Summary for Linux on commit `5e76ce1`

New failed tests found on Linux:

Trigger Notification From desktop should receive a notification on Ubuntu

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window
- Menu/window_menu MM-T824 should be minimized when keyboard shortcuts are pressed
- Menu/window_menu MM-T825 should be hidden when keyboard shortcuts are pressed
- header MM-T2637 Double-Clicking on the header should minimize/maximize the app MM-T2637_1 should maximize on double-clicking the header

Test Summary for macOS on commit `5e76ce1`

New failed tests found on macOS:

Trigger Notification From desktop should receive a notification on macOS

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

github-actions · 2024-10-08T14:15:43Z

Here are the test results below:

Test Summary for Linux on commit `2759c14`

New failed tests found on Linux:

Trigger Notification From desktop should receive a notification on Ubuntu

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window
- Menu/window_menu MM-T824 should be minimized when keyboard shortcuts are pressed
- Menu/window_menu MM-T825 should be hidden when keyboard shortcuts are pressed
- header MM-T2637 Double-Clicking on the header should minimize/maximize the app MM-T2637_1 should maximize on double-clicking the header

Test Summary for macOS on commit `2759c14`

New failed tests found on macOS:

Trigger Notification From desktop should receive a notification on macOS

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

github-actions · 2024-10-08T14:37:19Z

Here are the test results below:

Test Summary for Linux on commit `37ccff3`

New failed tests found on Linux:

Trigger Notification From desktop should receive a notification on Ubuntu

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window
- Menu/window_menu MM-T824 should be minimized when keyboard shortcuts are pressed
- Menu/window_menu MM-T825 should be hidden when keyboard shortcuts are pressed
- header MM-T2637 Double-Clicking on the header should minimize/maximize the app MM-T2637_1 should maximize on double-clicking the header

Test Summary for macOS on commit `37ccff3`

New failed tests found on macOS:

Trigger Notification From desktop should receive a notification on macOS

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

github-actions · 2024-10-08T14:42:38Z

Here are the test results below:

Test Summary for Linux on commit `37ccff3`

New failed tests found on Linux:

Trigger Notification From desktop should receive a notification on Ubuntu

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window
- Menu/window_menu MM-T824 should be minimized when keyboard shortcuts are pressed
- Menu/window_menu MM-T825 should be hidden when keyboard shortcuts are pressed
- header MM-T2637 Double-Clicking on the header should minimize/maximize the app MM-T2637_1 should maximize on double-clicking the header

Test Summary for macOS on commit `37ccff3`

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

github-actions · 2024-10-13T06:08:30Z

Here are the test results below:

Test Summary for Linux on commit `831ad45`

New failed tests found on Linux:

Trigger Notification From desktop should receive a notification on Ubuntu

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window
- Menu/window_menu MM-T824 should be minimized when keyboard shortcuts are pressed
- Menu/window_menu MM-T825 should be hidden when keyboard shortcuts are pressed
- header MM-T2637 Double-Clicking on the header should minimize/maximize the app MM-T2637_1 should maximize on double-clicking the header

Test Summary for macOS on commit `831ad45`

New failed tests found on macOS:

Trigger Notification From desktop should receive a notification on macOS

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

github-actions · 2024-10-13T06:12:29Z

Here are the test results below:

Test Summary for Linux on commit `831ad45`

New failed tests found on Linux:

Trigger Notification From desktop should receive a notification on Ubuntu

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window
- Menu/window_menu MM-T824 should be minimized when keyboard shortcuts are pressed
- Menu/window_menu MM-T825 should be hidden when keyboard shortcuts are pressed
- header MM-T2637 Double-Clicking on the header should minimize/maximize the app MM-T2637_1 should maximize on double-clicking the header

Test Summary for macOS on commit `831ad45`

New failed tests found on macOS:

Trigger Notification From desktop should receive a notification on macOS

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

github-actions · 2024-10-13T06:24:07Z

Here are the test results below:

Test Summary for Linux on commit `ee013e1`

New failed tests found on Linux:

Trigger Notification From desktop should receive a notification on Ubuntu

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window
- Menu/window_menu MM-T824 should be minimized when keyboard shortcuts are pressed
- Menu/window_menu MM-T825 should be hidden when keyboard shortcuts are pressed
- header MM-T2637 Double-Clicking on the header should minimize/maximize the app MM-T2637_1 should maximize on double-clicking the header

Test Summary for macOS on commit `ee013e1`

New failed tests found on macOS:

Trigger Notification From desktop should receive a notification on macOS

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

Test Summary for Windows on commit `ee013e1`

New failed tests found on Windows:

Trigger Notification From desktop should receive a notification on Windows

The following known failed tests have been fixed on Windows:
- application MM-T1304/MM-T1306 should open the app on the requested deep link

devinbinnie · 2024-10-15T13:52:10Z

e2e/modules/environment.js

@@ -31,7 +31,7 @@ const downloadsLocation = path.join(userDataDir, 'Downloads');
 const boundsInfoPath = path.join(userDataDir, 'bounds-info.json');
 const appUpdatePath = path.join(userDataDir, 'app-update.yml');
 const exampleURL = 'http://example.com/';
-const mattermostURL = process.env.MM_TEST_SERVER_URL || 'http://localhost:8065/';
+const mattermostURL = 'https://mattermost-pr-28334.test.mattermost.cloud/'; // process.env.MM_TEST_SERVER_URL || 'http://localhost:8065/';


I assume this wasn't intended to be merged?

yeah @devinbinnie .

sorry, I should have added a note. I'll remove it once the Dev PR gets into master

devinbinnie · 2024-10-15T13:52:26Z

e2e/modules/environment.js

@@ -266,8 +266,8 @@ module.exports = {
        await window.waitForSelector('#input_password-input');
        await window.waitForSelector('#saveSetting');

-        await window.type('#input_loginId', process.env.MM_TEST_USER_NAME);
-        await window.type('#input_password-input', process.env.MM_TEST_PASSWORD);
+        await window.type('#input_loginId', 'sysadmin');


e2e/specs/notification_trigger/helpers.js

init

5e76ce1

mm-cloud-bot added the release-note-none label Oct 8, 2024

yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 8, 2024

github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 8, 2024

only run badge check notif test

2759c14

yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 8, 2024

github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 8, 2024

update test steps

37ccff3

yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 8, 2024

github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 8, 2024

test linux

831ad45

yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 13, 2024

github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 13, 2024

fix windows e2e desktop

ee013e1

yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 13, 2024

github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 13, 2024

add test for mac

c989127

yasserfaraazkhan marked this pull request as ready for review October 15, 2024 12:19

yasserfaraazkhan requested review from devinbinnie and larkox October 15, 2024 12:20

devinbinnie reviewed Oct 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(e2e): Verify Test Notification on Desktop #3162

feat(e2e): Verify Test Notification on Desktop #3162

yasserfaraazkhan commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024

github-actions bot commented Oct 8, 2024

github-actions bot commented Oct 8, 2024

github-actions bot commented Oct 8, 2024

github-actions bot commented Oct 13, 2024

github-actions bot commented Oct 13, 2024

github-actions bot commented Oct 13, 2024

devinbinnie Oct 15, 2024

yasserfaraazkhan Oct 15, 2024

devinbinnie Oct 15, 2024

feat(e2e): Verify Test Notification on Desktop #3162

Are you sure you want to change the base?

feat(e2e): Verify Test Notification on Desktop #3162

Conversation

yasserfaraazkhan commented Oct 8, 2024 • edited Loading

github-actions bot commented Oct 8, 2024

Test Summary for Linux on commit 5e76ce1

Test Summary for macOS on commit 5e76ce1

github-actions bot commented Oct 8, 2024

Test Summary for Linux on commit 2759c14

Test Summary for macOS on commit 2759c14

github-actions bot commented Oct 8, 2024

Test Summary for Linux on commit 37ccff3

Test Summary for macOS on commit 37ccff3

github-actions bot commented Oct 8, 2024

Test Summary for Linux on commit 37ccff3

Test Summary for macOS on commit 37ccff3

github-actions bot commented Oct 13, 2024

Test Summary for Linux on commit 831ad45

Test Summary for macOS on commit 831ad45

github-actions bot commented Oct 13, 2024

Test Summary for Linux on commit 831ad45

Test Summary for macOS on commit 831ad45

github-actions bot commented Oct 13, 2024

Test Summary for Linux on commit ee013e1

Test Summary for macOS on commit ee013e1

Test Summary for Windows on commit ee013e1

devinbinnie Oct 15, 2024

Choose a reason for hiding this comment

yasserfaraazkhan Oct 15, 2024

Choose a reason for hiding this comment

devinbinnie Oct 15, 2024

Choose a reason for hiding this comment

yasserfaraazkhan commented Oct 8, 2024 •

edited

Loading

Test Summary for Linux on commit `5e76ce1`

Test Summary for macOS on commit `5e76ce1`

Test Summary for Linux on commit `2759c14`

Test Summary for macOS on commit `2759c14`

Test Summary for Linux on commit `37ccff3`

Test Summary for macOS on commit `37ccff3`

Test Summary for Linux on commit `37ccff3`

Test Summary for macOS on commit `37ccff3`

Test Summary for Linux on commit `831ad45`

Test Summary for macOS on commit `831ad45`

Test Summary for Linux on commit `831ad45`

Test Summary for macOS on commit `831ad45`

Test Summary for Linux on commit `ee013e1`

Test Summary for macOS on commit `ee013e1`

Test Summary for Windows on commit `ee013e1`