Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blank page when initiating a search with no search criteria #7444

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Fix blank page when initiating a search with no search criteria #7444

merged 7 commits into from
Oct 15, 2024
+68 −52

Conversation

hamzawritescode
Copy link
Contributor

Summary

Fix blank page when initiating a search with no search criteria

Ticket Link

Fixes #7031

@mattermost-build
Copy link
Contributor

Hello @hamzawritescode,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@hamzawritescode
Copy link
Contributor Author

Also, upon approval, where can I claim my free Mattermost mug?

@hamzawritescode hamzawritescode mentioned this pull request Oct 5, 2024
Closed
@cwarnermm cwarnermm self-requested a review October 7, 2024 14:58
@cwarnermm cwarnermm added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Newest code from hamzawritescode has been published to preview environment for Git SHA e183b65

cwarnermm
cwarnermm approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hamzawritescode!

source/_templates/search.html Outdated Show resolved Hide resolved
source/_templates/search.html Outdated Show resolved Hide resolved
hamzawritescode and others added 2 commits October 8, 2024 17:54
@hamzawritescode @cwarnermm
Update source/_templates/search.html
a5b9bb1 
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
@hamzawritescode @cwarnermm
Update source/_templates/search.html
fc3dd76 
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
@hamzawritescode
Copy link
Contributor Author

There you go, @cwarnermm! Also, where can I claim my mug?

@cwarnermm
Copy link
Member

@hamzawritescode - Can you merge latest master into your fork please?

@hamzawritescode
Copy link
Contributor Author

All done!

@cwarnermm
Copy link
Member

@hamzawritescode - The master branch is updated at regular intervals. I recommend updating your fork permissions to allow remote edits. This would allow us to move forward with your PR while ensuring it remains updated to the master branch as it changes.

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories QA-wanted and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 10, 2024
@github-actions GitHub Actions
Copy link

Newest code from hamzawritescode has been published to preview environment for Git SHA 3077509

@varghesejose2020
Copy link
Contributor

@lindy65 please assign me to test this PR

@lindy65
Copy link
Contributor

lindy65 commented Oct 10, 2024

Assigned you for QA testing @varghesejose2020

You can test the changes using the preview environment here

@varghesejose2020
Copy link
Contributor

varghesejose2020 commented Oct 10, 2024 •
edited
Loading

Screenshot_20241010_220915
LGTM👍

Got one scenario if we type space on search bar and click enter Please enter at least one search term. this message is shown and at the end some results are shown on that page.Do both of these cases need to be displayed? Please refer the video

Screenrecording_20241010_220614.mp4

@lindy65

@lindy65
Copy link
Contributor

lindy65 commented Oct 10, 2024

@cwarnermm - can you help with Varghese's question above please?

@cwarnermm
Copy link
Member

cwarnermm commented Oct 10, 2024 •
edited
Loading

Good question, @varghesejose2020! I consider this use case a pass (the docs behave as I'd expect). Thank you for identifying an edge case I hadn't considered!

@lindy65
Copy link
Contributor

lindy65 commented Oct 10, 2024

Thanks @cwarnermm :)

Thanks for testing @varghesejose2020 - counted towards Hacktoberfest!

@lindy65 lindy65 removed the QA-wanted label Oct 10, 2024
@varghesejose2020 varghesejose2020 mentioned this pull request Oct 11, 2024
Closed
1 task
@hamzawritescode
Copy link
Contributor Author

@cwarnermm
image
Done

@lindy65 lindy65 added the QA-done QA review is complete label Oct 14, 2024
@cwarnermm cwarnermm added the 3: Reviews Complete All reviewers have approved the pull request label Oct 15, 2024
@cwarnermm cwarnermm removed the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 15, 2024
@cwarnermm cwarnermm merged commit 365a14b into mattermost:master Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null QA-done QA review is complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help Wanted: User sees blank page when initiating a search with no search criteria
5 participants
@hamzawritescode @mattermost-build @cwarnermm @varghesejose2020 @lindy65