Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: User satisfaction survey plugin config #7445

Conversation

TomerPacific
Copy link
Contributor

Summary

This pull request includes updates to the configuration settings documentation for the Mattermost User Satisfaction Surveys plugin. The changes primarily involve updating the config.json paths and adding environment variable information.

Ticket Link

Resolves #7429

screen

@mattermost-build
Copy link
Contributor

Hello @TomerPacific,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm cwarnermm self-requested a review October 7, 2024 14:59
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Newest code from TomerPacific has been published to preview environment for Git SHA da8ad64

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Newest code from TomerPacific has been published to preview environment for Git SHA b16edef

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @TomerPacific!

@cwarnermm cwarnermm removed the 2: Editor Review Requires review by an editor label Oct 9, 2024
@lindy65 lindy65 self-assigned this Oct 9, 2024
@Rutam21
Copy link
Contributor

Rutam21 commented Oct 10, 2024

@lindy65 Please assign this issue for QA Testing. Thanks.

@lindy65
Copy link
Contributor

lindy65 commented Oct 10, 2024

Assigned to you for testing @Rutam21

You can test the changes using the preview environment here

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 11, 2024

The changes through this PR have been tested in the preview environment and work as expected.

Additional information on the config.json setting and Environment variable has been added in the User Satisfaction Surveys section under the Enable plugin and Enable user satisfaction survey sub-sections. I've attached a video as a confirmation.

PR-7445.QA.Testing.mp4

cc: @lindy65

@lindy65
Copy link
Contributor

lindy65 commented Oct 13, 2024

Thank you @Rutam21 - counted towards Hacktoberfest!

cc @cwarnermm

@lindy65 lindy65 added QA-done QA review is complete and removed QA-wanted labels Oct 13, 2024
@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 15, 2024
@cwarnermm cwarnermm merged commit 6e1060f into mattermost:master Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null QA-done QA review is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Wanted: Document missing User Satisfaction Survey plugin configuration
5 participants