-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-45894] Add documentation for Calls EnableDCSignaling setting #7449
Conversation
Newest code from mattermost has been published to preview environment for Git SHA a8de25b |
1 similar comment
Newest code from mattermost has been published to preview environment for Git SHA a8de25b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an overall question about this feature -- when would it cease to be experimental? It seems like a pretty harmless feature with only benefits.
@cpoile Given this can affect how media tracks are shared, a simple bug could potentially cause serious communication issues. Being cautious makes sense to me, at least for a few release cycles since this has not been thoroughly tested in production yet. |
Yep, makes sense -- just want clarity on what the conditions will be. Thanks! |
Enable DC signaling (Experimental) | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
.. config:setting:: plugins-enabledcsignaling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point on this page, search meta data started being positioned below the section heading, rather than directly above the section header. As I scroll back, I see a few config settings organized this way. It's my understanding that search meta data needs to be directly above the section heading to return results correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, not sure either, but it should look better now.
Newest code from mattermost has been published to preview environment for Git SHA 1fcb724 |
I will go ahead and merge this since we are releasing the plugin to the Marketplace, and the documentation should be up by then. |
Summary
Adding documentation for the new experimental
EnableDCSignaling
setting introduced in mattermost/mattermost-plugin-calls#865To be merged before MM v10.2 release.
Ticket Link
https://mattermost.atlassian.net/browse/MM-45894