Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-45894] Add documentation for Calls EnableDCSignaling setting #7449

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

streamer45
Copy link
Contributor

Summary

Adding documentation for the new experimental EnableDCSignaling setting introduced in mattermost/mattermost-plugin-calls#865

To be merged before MM v10.2 release.

Ticket Link

https://mattermost.atlassian.net/browse/MM-45894

@streamer45 streamer45 added 1: Dev Review Requires review by a core commiter Do Not Merge Should not be merged until this label is removed 2: Editor Review Requires review by an editor labels Oct 7, 2024
@streamer45 streamer45 self-assigned this Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Newest code from mattermost has been published to preview environment for Git SHA a8de25b

1 similar comment
Copy link

github-actions bot commented Oct 7, 2024

Newest code from mattermost has been published to preview environment for Git SHA a8de25b

@cwarnermm cwarnermm added this to the v10.2.0 milestone Oct 8, 2024
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an overall question about this feature -- when would it cease to be experimental? It seems like a pretty harmless feature with only benefits.

@cpoile cpoile removed the 1: Dev Review Requires review by a core commiter label Oct 9, 2024
@streamer45
Copy link
Contributor Author

As an overall question about this feature -- when would it cease to be experimental? It seems like a pretty harmless feature with only benefits.

@cpoile Given this can affect how media tracks are shared, a simple bug could potentially cause serious communication issues. Being cautious makes sense to me, at least for a few release cycles since this has not been thoroughly tested in production yet.

@cpoile
Copy link
Member

cpoile commented Oct 9, 2024

Yep, makes sense -- just want clarity on what the conditions will be. Thanks!

Enable DC signaling (Experimental)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.. config:setting:: plugins-enabledcsignaling
Copy link
Member

@cwarnermm cwarnermm Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point on this page, search meta data started being positioned below the section heading, rather than directly above the section header. As I scroll back, I see a few config settings organized this way. It's my understanding that search meta data needs to be directly above the section heading to return results correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not sure either, but it should look better now.

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor labels Oct 11, 2024
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 1fcb724

@streamer45 streamer45 removed the Do Not Merge Should not be merged until this label is removed label Oct 14, 2024
@streamer45
Copy link
Contributor Author

I will go ahead and merge this since we are releasing the plugin to the Marketplace, and the documentation should be up by then.

@streamer45 streamer45 merged commit 27cddb4 into master Oct 14, 2024
4 checks passed
@streamer45 streamer45 deleted the MM-45894 branch October 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants