Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documentation for Newly Supported Import/Export Components #7463

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update Documentation for Newly Supported Import/Export Components #7463

wants to merge 7 commits into from
+9 −2

Conversation

arilloid
Copy link

@arilloid arilloid commented Oct 9, 2024

Hello Mattermost Team,

I have added newly supported components (Mattermost v10.1) to onboard/bulk-loading-data.rst and manage/bulk-export-tool.rst.

Summary

I made sure that both files mention the following components:

  • direct and group message channels
  • direct and group message read/unread status
  • threaded discussions

onboard/bulk-loading-data.rst :

https://github.com/arilloid/docs/blob/issue-7458/source/onboard/bulk-loading-data.rst

image

manage/bulk-export-tool.rst:

https://github.com/arilloid/docs/blob/issue-7458/source/manage/bulk-export-tool.rst

image

Ticket Link

Fixes #7458

@arilloid
Added newly supported data types to the list
d8a99e0 
Mattermost v10.1 imports and exports will support:

- direct and group channels
- direct and group channel unread/read state
- threaded discussion memberships
@arilloid
Added newly supported data types to the list
dbdc9a9 
Mattermost v10.1 imports and exports will support:

- direct and group channels
- direct and group channel unread/read state
- threaded discussion memberships
@mattermost-build
Copy link
Contributor

Hello @arilloid,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@arilloid
Copy link
Author

arilloid commented Oct 9, 2024

I also wanted to mention that I have signed the license agreement.

And ask if you would like me to add the newly supported datatypes to the source/manage/bulk-export-data.rst:

image

@cwarnermm cwarnermm self-requested a review October 9, 2024 14:18
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Newest code from arilloid has been published to preview environment for Git SHA dbdc9a9

@cwarnermm
Copy link
Member

Thank you, @arilloid! Both for the docs PR and for your careful eye for detail! Yes, please do make the same updates to the manage/bulk-export-data.rst source file.

@arilloid
Merge branch 'mattermost:master' into issue-7458
930d849
@arilloid
Added newly supported types to the list
2bf5a38 
Mattermost v10.1 imports and exports will support:

- direct and group channels
- direct and group channel unread/read state
- threaded discussion memberships
@arilloid
Copy link
Author

arilloid commented Oct 9, 2024

Thank you for being so responsive @cwarnermm!

I have updated the manage/bulk-export-data.rs source file.

https://github.com/arilloid/docs/blob/issue-7458/source/manage/bulk-export-data.rst
image

cwarnermm
cwarnermm reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @arilloid!!

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 11, 2024

@lindy65 Please assign this PR to me for QA Testing. Thanks.

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 12, 2024 •
edited
Loading

@cwarnermm Please generate another preview environment so that it includes the latest commits in the PR. Thanks.

@lindy65 lindy65 added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 13, 2024
@lindy65
Copy link
Contributor

lindy65 commented Oct 13, 2024

Assigned to you @Rutam21 and generated an updated preview environment

@github-actions GitHub Actions
Copy link

Newest code from arilloid has been published to preview environment for Git SHA 783a087

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 14, 2024

The changes through this PR have been tested in the preview environment and all new iterations are available in the mentioned pages.

  • Changes have been made to the following pages.

    • Bulk Loading Data
    • Bulk Export Data
    • Bulk Export Tool

  • The following new supported components have been added to the existing list of components on the pages mentioned above.

    • direct and group message channels
    • direct and group message read/unread status
    • threaded discussions

I've attached a video as a confirmation.

PR-7463.QA.mp4

cc: @lindy65

@lindy65
Copy link
Contributor

lindy65 commented Oct 14, 2024

Thanks for testing @Rutam21 - counted towards Hacktoberfest!

cc @cwarnermm

@lindy65 lindy65 removed the QA-wanted label Oct 14, 2024
@lindy65 lindy65 added the QA-done QA review is complete label Oct 14, 2024
@arilloid arilloid changed the title Update Documentation for Newly Supported Import/Export Components [GH -#7458] Update Documentation for Newly Supported Import/Export Components Oct 14, 2024
@arilloid arilloid changed the title [GH -#7458] Update Documentation for Newly Supported Import/Export Components Update Documentation for Newly Supported Import/Export Components Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2: Editor Review Requires review by an editor Contributor Hacktoberfest null preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories QA-done QA review is complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help Wanted: Update documentation on components that are imported/exported
5 participants
@arilloid @mattermost-build @cwarnermm @Rutam21 @lindy65