Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Notifications flow diagrams recreation #7470

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TomerPacific
Copy link
Contributor

@TomerPacific TomerPacific commented Oct 10, 2024

Summary

This PR recreates the following three diagrams using draw.io

  1. Desktop Notification Flow Chart
  2. Email Notification Flow Chart
  3. Push Notification Flow Chart

All files are in a draw.io format and have been placed inside the images directory with an equivalent name to the same flow chart in .png format.

Ticket Link

Resolves #7348

@mattermost-build
Copy link
Contributor

Hello @TomerPacific,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm cwarnermm self-requested a review October 11, 2024 12:54
@cwarnermm cwarnermm added the 2: Editor Review Requires review by an editor label Oct 11, 2024
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TomerPacific!

@lindy65 lindy65 added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 11, 2024
@lindy65 lindy65 self-assigned this Oct 11, 2024
Copy link

Newest code from TomerPacific has been published to preview environment for Git SHA 8280093

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 11, 2024

@lindy65 I would like to do the QA testing for this PR. Please assign this to me. Thanks.

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 12, 2024

The changes in this PR have been verified and they strictly follow the guidelines mentioned in the original ticket.

Here's a summary of the observed outcomes through this PR.

  • Mattermost desktop notification flow chart XML has been added with a .drawio extension.
  • Mattermost email notification flow chart XML has been added with a .drawio extension.
  • Mattermost desktop notification flow chart XML has been added with a .drawio extension.
  • All these XML files have been added in the /images folder as advised in the original ticket.
  • All these XML files bear the same name as the existing PNG flow diagram files.
  • The colors/fonts/text and general appearance are similar to the current flow diagram published in the product documentation.
  • The XML files for these flow charts can be opened and edited further using Draw IO as instructed in the original ticket.

I've attached a video as a confirmation, comparing the existing flow diagrams and the newly created flow charts, and have also tried editing it successfully.

PR-7470.QA.Testing.mp4

cc: @lindy65

@lindy65 lindy65 added QA-done QA review is complete and removed QA-wanted labels Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Editor Review Requires review by an editor Contributor Hacktoberfest null preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories QA-done QA review is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Wanted: Re-create notification flow diagram source files using draw.io
5 participants