Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Azure Container Offer docs #7472

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

toninis
Copy link
Contributor

@toninis toninis commented Oct 11, 2024

Summary

  • Upgrade python and various components on our workflows
  • Create the Azure Container Offer documentation
  • Changed a bit the orientation and the way it looks on the main site

Ticket Link

Copy link

Newest code from mattermost has been published to preview environment for Git SHA d01925c

@mattermost mattermost deleted a comment from github-actions bot Oct 11, 2024
@toninis
Copy link
Contributor Author

toninis commented Oct 11, 2024

@cwarnermm Any idea why this happens ?
image

Infrastructure Pre-requisites
-----------------------------

PostgreSQL v11.0+ Database
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend this to be v13

Copy link
Member

@cwarnermm cwarnermm Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied this feedback in my commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump it separately along with other instances from these docs that still reflect 11+?

@cwarnermm
Copy link
Member

cwarnermm commented Oct 11, 2024

@toninis - Yes, I can see some RST-specific syntax issues that are resulting in the docs output you're seeing. Are you open to me committing changes to this PR directly? If so, I'll pull your branch down to do so.

@toninis
Copy link
Contributor Author

toninis commented Oct 11, 2024

@toninis - Yes, I can see some RST-specific syntax issues that are resulting in the docs output you're seeing. Are you open to me committing changes to this PR directly? If so, I'll pull your fork down to do so.

Feel free of course . And take your time . Hopefully we will get this shipped next week .
Do your thang 🚀

@cwarnermm
Copy link
Member

@toninis - I've applied editorial and syntax updates. Currently, the new Azure AKS deploy page is listed directly after the Kubernetes page in the nav pane. If you'd prefer to see a nested approach instead with parent/child pages, let me know!

Copy link

Newest code from mattermost has been published to preview environment for Git SHA f871c43

Copy link

Newest code from mattermost has been published to preview environment for Git SHA b4fba7b

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @toninis! Left couple comments but overall looks good to me.

source/install/install-kubernetes-aks.rst Outdated Show resolved Hide resolved
.. include:: ../_static/badges/ent-only.rst
:start-after: :nosearch:

If your deployment option is for more than ``100 users``, you must have more than 2 nodes on your AKS cluster to support High Availability, and you must provide a valid Mattermost License file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though we don't have scaling info yet using Azure, I wonder if we should refer them (temporarily) to https://docs.mattermost.com/guides/scale-mattermost.html so they could have some guidance (by converting AWS resource to Azure).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not about scaling as such but giving the option to do so . We can limit the installation to some users if we want to but if someone purchases a license then they should be able to scale a bit.

Infrastructure Pre-requisites
-----------------------------

PostgreSQL v11.0+ Database
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump it separately along with other instances from these docs that still reflect 11+?

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 69b9d1a

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @toninis!

@toninis toninis requested a review from nab-77 October 14, 2024 09:44
@toninis
Copy link
Contributor Author

toninis commented Oct 14, 2024

@toninis - I've applied editorial and syntax updates. Currently, the new Azure AKS deploy page is listed directly after the Kubernetes page in the nav pane. If you'd prefer to see a nested approach instead with parent/child pages, let me know!

I am 3/5 but I think a nested approach is better meaning that we support Kubernetes installation but in the meantime we have cloud specific instructions on each cloud .
WDYT ?

cc: @nab-77

Copy link
Contributor

@nab-77 nab-77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update. Agree that elevating Azure to same level as all deployments is the way to go (we might revisit this nesting when we have other K8s CSP deployments).

@toninis
Copy link
Contributor Author

toninis commented Oct 14, 2024

Great update. Agree that elevating Azure to same level as all deployments is the way to go (we might revisit this nesting when we have other K8s CSP deployments).

Perfect. We are good to merge then . @cwarnermm with your blessing as always 😄

@toninis toninis force-pushed the feat/create-azure-container-offer-docs branch from 69b9d1a to de1430e Compare October 15, 2024 10:50
Copy link

Newest code from mattermost has been published to preview environment for Git SHA de1430e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants