-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create Azure Container Offer docs #7472
base: master
Are you sure you want to change the base?
Conversation
50e59d4
to
d01925c
Compare
Newest code from mattermost has been published to preview environment for Git SHA d01925c |
@cwarnermm Any idea why this happens ? |
Infrastructure Pre-requisites | ||
----------------------------- | ||
|
||
PostgreSQL v11.0+ Database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend this to be v13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've applied this feedback in my commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump it separately along with other instances from these docs that still reflect 11+?
@toninis - Yes, I can see some RST-specific syntax issues that are resulting in the docs output you're seeing. Are you open to me committing changes to this PR directly? If so, I'll pull your branch down to do so. |
Feel free of course . And take your time . Hopefully we will get this shipped next week . |
@toninis - I've applied editorial and syntax updates. Currently, the new Azure AKS deploy page is listed directly after the Kubernetes page in the nav pane. If you'd prefer to see a nested approach instead with parent/child pages, let me know! |
Newest code from mattermost has been published to preview environment for Git SHA f871c43 |
Newest code from mattermost has been published to preview environment for Git SHA b4fba7b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @toninis! Left couple comments but overall looks good to me.
.. include:: ../_static/badges/ent-only.rst | ||
:start-after: :nosearch: | ||
|
||
If your deployment option is for more than ``100 users``, you must have more than 2 nodes on your AKS cluster to support High Availability, and you must provide a valid Mattermost License file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though we don't have scaling info yet using Azure, I wonder if we should refer them (temporarily) to https://docs.mattermost.com/guides/scale-mattermost.html so they could have some guidance (by converting AWS resource to Azure).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not about scaling as such but giving the option to do so . We can limit the installation to some users if we want to but if someone purchases a license then they should be able to scale a bit.
Infrastructure Pre-requisites | ||
----------------------------- | ||
|
||
PostgreSQL v11.0+ Database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump it separately along with other instances from these docs that still reflect 11+?
Newest code from mattermost has been published to preview environment for Git SHA 69b9d1a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @toninis!
I am 3/5 but I think a nested approach is better meaning that we support Kubernetes installation but in the meantime we have cloud specific instructions on each cloud . cc: @nab-77 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update. Agree that elevating Azure to same level as all deployments is the way to go (we might revisit this nesting when we have other K8s CSP deployments).
Perfect. We are good to merge then . @cwarnermm with your blessing as always 😄 |
Co-authored-by: Saturnino Abril <5334504+saturninoabril@users.noreply.github.com>
69b9d1a
to
de1430e
Compare
Newest code from mattermost has been published to preview environment for Git SHA de1430e |
Summary
Ticket Link