Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update share-links.rst #7481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Good-Soma
Copy link

Fixes

I added a passage that describe how deep link can be formatted, it value with an example that clarify the message as a subsection in share-links.rst file as you instructed.

I made the content to correlate with the previous note that had been written.

Summary

Ticket Link

I added deep link configuration,  the value and a few URL examples to for better clarity.
@mattermost-build
Copy link
Contributor

Hello @Good-Soma,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@Good-Soma
Copy link
Author

Hello,
I just sent a pull request that address the #7430 issue. Please, review it and merge it, if is okay, or notify me if I need to make any modification. Thanks

@Good-Soma
Copy link
Author

Hello @Good-Soma,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla
I have signed the CLA in the website that I was directed to, but the check isn't turning green. I click on the detail beside the required box it showed, and downloaded the file in it, I wasn't able to open the file. Any hint?

@Good-Soma
Copy link
Author

Okay, it has work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants