Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove end user message for unsupported servers #8404

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Remove end user message for unsupported servers #8404

merged 2 commits into from
Dec 12, 2024

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Dec 10, 2024

Summary

Remove end user message for unsupported servers. We keep the admin message.

Ticket Link

Fix https://mattermost.atlassian.net/browse/MM-59408

Release Note

End users won't receive messages about being on unsupported servers

@larkox larkox requested a review from marianunez December 10, 2024 14:55
@larkox larkox requested a review from a team December 10, 2024 14:56
@larkox larkox added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 10, 2024
marianunez
marianunez approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @larkox !

@amyblais once this is merged we can update the ESR version again so we reactivate these alerts for admins.

@marianunez marianunez requested a review from pvev December 10, 2024 17:16
pvev
pvev approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@pvev pvev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pvev pvev removed the 2: Dev Review Requires review by a core commiter label Dec 10, 2024
@marianunez marianunez added this to the v2.24.0 milestone Dec 10, 2024
@yasserfaraazkhan yasserfaraazkhan added the Build Apps for PR Build the mobile app for iOS and Android to test label Dec 10, 2024
@yasserfaraazkhan
Copy link
Contributor

@larkox can you share QA steps for this change?

@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Dec 11, 2024
@larkox
Copy link
Contributor Author

larkox commented Dec 11, 2024 •
edited
Loading

@yasserfaraazkhan

  • Setup a server in any version previous to 8.1.0
  • Log in in such server with the mobile app

Before fix:

  • Normal users will receive an alert saying "Your server, {serverDisplayName}, is running an unsupported server version. You may experience compatibility issues that cause crashes or severe bugs breaking core functionality of the app. Please contact your System Administrator to upgrade your Mattermost server."
  • Admin users will receive an alert saying "Your server, {serverDisplayName}, is running an unsupported server version. Users will be exposed to compatibility issues that cause crashes or severe bugs breaking core functionality of the app. Upgrading to server version {supportedServerVersion} or later is required."

After the fix:

  • Normal users will not receive any alert
  • Admin users will receive an alert saying "Your server, {serverDisplayName}, is running an unsupported server version. Users will be exposed to compatibility issues that cause crashes or severe bugs breaking core functionality of the app. Upgrading to server version {supportedServerVersion} or later is required."

There is logic to not show this notice but once every 24 hours, so you may have to log out and log back in to see it again.

@yasserfaraazkhan
Copy link
Contributor

Thank you @larkox
I'll try building app locally and test. I think buid app on Forked repos does not build apps

@larkox
Copy link
Contributor Author

larkox commented Dec 11, 2024

@yasserfaraazkhan Sorry about that 😅 I thought I pushed that to the main repo, but it seems I didn't.

yasserfaraazkhan
yasserfaraazkhan approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected.

before :
Screenshot 2024-12-12 at 4 42 27 PM

after change: User does not see any alert

only admin can see below alert
Screenshot 2024-12-12 at 4 51 52 PM

@larkox larkox added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Dec 12, 2024
@larkox larkox merged commit da38976 into mattermost:main Dec 12, 2024
4 checks passed
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request Dec 12, 2024
@larkox @mattermost-build
Remove end user message for unsupported servers (#8404)
b928104 
* Remove end user message for unsupported servers

* Update test

(cherry picked from commit da38976)
@mattermost-build mattermost-build mentioned this pull request Dec 12, 2024
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 12, 2024
amyblais pushed a commit that referenced this pull request Dec 12, 2024
@mattermost-build @larkox
Remove end user message for unsupported servers (#8404) (#8409)
5dcdbf3 
* Remove end user message for unsupported servers

* Update test

(cherry picked from commit da38976)

Co-authored-by: Daniel Espino García <larkox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

@pvev pvev pvev approved these changes

@marianunez marianunez marianunez approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Build Apps for PR Build the mobile app for iOS and Android to test CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note
Projects
None yet
Milestone
v2.24.0
Development

Successfully merging this pull request may close these issues.
7 participants
@larkox @yasserfaraazkhan @mattermost-build @marianunez @pvev @amyblais @mm-cloud-bot