Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached store part #1: API #457

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Cached store part #1: API #457

wants to merge 28 commits into from

Conversation

levb
Copy link
Contributor

@levb levb commented Feb 19, 2023

This is a precursor PR for the cached store, it adds an API struct to pass around static API pointers, and makes it available in incoming.Request

Lev Brouk and others added 28 commits January 30, 2023 14:14
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
…gin-apps into lev-MM-48793-bot-subs-simplified
…ost/mattermost-plugin-apps into leb-cached-1
@levb levb added the 2: Dev Review Requires review by a core committer label Feb 19, 2023
@levb levb requested a review from mickmister February 19, 2023 14:04
@levb levb requested a review from hanzei February 19, 2023 14:04
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Patch coverage: 18.79% and project coverage change: +0.56 🎉

Comparison is base (8bfe37b) 20.31% compared to head (061a175) 20.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   20.31%   20.88%   +0.56%     
==========================================
  Files          78       79       +1     
  Lines        5266     5416     +150     
==========================================
+ Hits         1070     1131      +61     
- Misses       4066     4153      +87     
- Partials      130      132       +2     
Impacted Files Coverage Δ
apps/goapp/http.go 0.00% <0.00%> (ø)
server/config/service.go 0.00% <0.00%> (ø)
server/config/test_service.go 0.00% <0.00%> (ø)
server/proxy/enable.go 4.05% <0.00%> (-0.36%) ⬇️
server/proxy/expand_getter.go 0.00% <0.00%> (ø)
server/proxy/install.go 0.00% <0.00%> (ø)
server/proxy/invoke_oauth2.go 0.00% <0.00%> (ø)
server/proxy/invoke_static.go 18.91% <0.00%> (ø)
server/proxy/invoke_webhook.go 0.00% <0.00%> (ø)
server/proxy/notify.go 0.00% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@levb levb mentioned this pull request Feb 19, 2023
8 tasks
Base automatically changed from lev-MM-48793-bot-subs-simplified to master February 19, 2023 20:43
@hanzei hanzei added this to the v1.3.0 milestone Feb 21, 2023
@hanzei hanzei added the Awaiting Submitter Action Blocked on the author label Feb 23, 2023
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei removed 2: Dev Review Requires review by a core committer Awaiting Submitter Action Blocked on the author labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants